From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id 8E423386EC42
 for <gdb-patches@sourceware.org>; Fri, 24 Apr 2020 16:27:08 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8E423386EC42
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=gnu.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eliz@gnu.org
Received: from fencepost.gnu.org ([2001:470:142:3::e]:32898)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1jS1AR-0000oN-8j; Fri, 24 Apr 2020 12:27:07 -0400
Received: from [176.228.60.248] (port=3858 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1jS1AO-00079v-W6; Fri, 24 Apr 2020 12:27:06 -0400
Date: Fri, 24 Apr 2020 19:26:51 +0300
Message-Id: <83h7x8alys.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Hannes Domani <ssbssa@yahoo.de>
Cc: gdb-patches@sourceware.org
In-Reply-To: <20200424155944.17332-1-ssbssa@yahoo.de> (message from Hannes
 Domani via Gdb-patches on Fri, 24 Apr 2020 17:59:44 +0200)
Subject: Re: [PATCH] Implement debugging of WOW64 processes in gdbserver
References: <20200424155944.17332-1-ssbssa.ref@yahoo.de>
 <20200424155944.17332-1-ssbssa@yahoo.de>
X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Apr 2020 16:27:09 -0000

> Date: Fri, 24 Apr 2020 17:59:44 +0200
> From: Hannes Domani via Gdb-patches <gdb-patches@sourceware.org>
> 
> +#ifdef __x86_64__
> +  if (wow64_process)
> +    ok = (*win32_EnumProcessModulesEx) (current_process_handle,
> +					DllHandle,
> +					sizeof (HMODULE),
> +					&cbNeeded,
> +					LIST_MODULES_32BIT);

If win32_EnumProcessModulesEx is a NULL point (i.e. its load from the
DLL failed, because we are on an older Windows version), the above
will segfault, no?  Do we want to support WOW64 debugging on systems
older than Vista?

Thanks.