From: Eli Zaretskii <eliz@gnu.org>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix PR14371: doc on =breakpoint-deleted
Date: Sat, 04 Aug 2012 07:04:00 -0000 [thread overview]
Message-ID: <83fw83b0kh.fsf@gnu.org> (raw)
In-Reply-To: <1344053058-19490-1-git-send-email-yao@codesourcery.com>
> From: Yao Qi <yao@codesourcery.com>
> Date: Sat, 4 Aug 2012 12:04:18 +0800
>
> We have an inconsistency between GDB and doc on '=breakpoint-deleted'.
> The doc says "=breakpoint-deleted,bpkt={}", while the actual behavior
> is "=breakpoint-deleted,id=". I treat it as an error in doc, so fix
> it in doc side.
Thanks.
>
> gdb/doc:
>
> 2012-08-04 Yao Qi <yao@codesourcery.com>
>
> Fix PR14371.
>
> * gdb.texinfo (GDB/MI Async Records): Fix the doc for
> '=breakpoint-deleted'.
> ---
> gdb/doc/gdb.texinfo | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index b7b15ec..96fa5e2 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -27609,13 +27609,14 @@ thread groups.
>
> @item =breakpoint-created,bkpt=@{...@}
> @itemx =breakpoint-modified,bkpt=@{...@}
> -@itemx =breakpoint-deleted,bkpt=@{...@}
> +@itemx =breakpoint-deleted,id=@var{number}
> Reports that a breakpoint was created, modified, or deleted,
> respectively. Only user-visible breakpoints are reported to the MI
> user.
>
> The @var{bkpt} argument is of the same form as returned by the various
> -breakpoint commands; @xref{GDB/MI Breakpoint Commands}.
> +breakpoint commands; @xref{GDB/MI Breakpoint Commands}. The @var{id}
> +argument is the id of the breakpoint. ^^^^^^^^
^^^^^^^^^^^^^^^^^^^^^^^^
Not "@var{id}", but "@var{number}", for consistency with the
description above. Also, I'd prefer "the ordinal number of the
breakpoint" instead of the end of the last sentence, because "id of
the breakpoint" doesn't really say what it is.
OK with those changes.
next prev parent reply other threads:[~2012-08-04 7:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-04 4:05 Yao Qi
2012-08-04 7:04 ` Eli Zaretskii [this message]
2012-08-06 14:23 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fw83b0kh.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox