From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9355 invoked by alias); 4 Aug 2012 07:04:22 -0000 Received: (qmail 9345 invoked by uid 22791); 4 Aug 2012 07:04:20 -0000 X-SWARE-Spam-Status: No, hits=-4.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 04 Aug 2012 07:04:04 +0000 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0M8700700Y6A6800@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Sat, 04 Aug 2012 10:04:02 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M87007CRYAP1Y70@a-mtaout23.012.net.il>; Sat, 04 Aug 2012 10:04:02 +0300 (IDT) Date: Sat, 04 Aug 2012 07:04:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH] Fix PR14371: doc on =breakpoint-deleted In-reply-to: <1344053058-19490-1-git-send-email-yao@codesourcery.com> To: Yao Qi Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83fw83b0kh.fsf@gnu.org> References: <1344053058-19490-1-git-send-email-yao@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00135.txt.bz2 > From: Yao Qi > Date: Sat, 4 Aug 2012 12:04:18 +0800 > > We have an inconsistency between GDB and doc on '=breakpoint-deleted'. > The doc says "=breakpoint-deleted,bpkt={}", while the actual behavior > is "=breakpoint-deleted,id=". I treat it as an error in doc, so fix > it in doc side. Thanks. > > gdb/doc: > > 2012-08-04 Yao Qi > > Fix PR14371. > > * gdb.texinfo (GDB/MI Async Records): Fix the doc for > '=breakpoint-deleted'. > --- > gdb/doc/gdb.texinfo | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index b7b15ec..96fa5e2 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -27609,13 +27609,14 @@ thread groups. > > @item =breakpoint-created,bkpt=@{...@} > @itemx =breakpoint-modified,bkpt=@{...@} > -@itemx =breakpoint-deleted,bkpt=@{...@} > +@itemx =breakpoint-deleted,id=@var{number} > Reports that a breakpoint was created, modified, or deleted, > respectively. Only user-visible breakpoints are reported to the MI > user. > > The @var{bkpt} argument is of the same form as returned by the various > -breakpoint commands; @xref{GDB/MI Breakpoint Commands}. > +breakpoint commands; @xref{GDB/MI Breakpoint Commands}. The @var{id} > +argument is the id of the breakpoint. ^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ Not "@var{id}", but "@var{number}", for consistency with the description above. Also, I'd prefer "the ordinal number of the breakpoint" instead of the end of the last sentence, because "id of the breakpoint" doesn't really say what it is. OK with those changes.