Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: tromey@redhat.com
Cc: pedro@codesourcery.com, gdb-patches@sourceware.org
Subject: Re: [RFA] Define EILSEQ if not defined by errno.h
Date: Mon, 13 Apr 2009 18:52:00 -0000	[thread overview]
Message-ID: <83eivwo08j.fsf@gnu.org> (raw)
In-Reply-To: <m363h8o5rl.fsf@fleche.redhat.com>

> Cc: Pedro Alves <pedro@codesourcery.com>, gdb-patches@sourceware.org
> From: Tom Tromey <tromey@redhat.com>
> Date: Mon, 13 Apr 2009 10:52:30 -0600
> 
> >>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
> 
> Eli> I'd like to hear Tom's opinion as well.  Tom?
> 
> I agree with all of Pedro's comments.

Thanks.  Here's what I actually committed:


2009-04-13  Eli Zaretskii  <eliz@gnu.org>

	* charset.c (EILSEQ): Define if not defined by system headers.

Index: gdb/charset.c
===================================================================
RCS file: /cvs/src/src/gdb/charset.c,v
retrieving revision 1.19
diff -u -r1.19 charset.c
--- gdb/charset.c	25 Mar 2009 00:58:34 -0000	1.19
+++ gdb/charset.c	13 Apr 2009 18:48:45 -0000
@@ -89,6 +89,15 @@
 #undef ICONV_CONST
 #define ICONV_CONST const
 
+/* Some systems, don't have EILSEQ, so we define it here, but not as
+   EINVAL, because callers of `iconv' want to distinguish EINVAL and
+   EILSEQ.  This is what iconv.h from libiconv does as well.  Note
+   that wchar.h may also define EILSEQ, so this needs to be after we
+   include wchar.h, which happens in defs.h through gdb_wchar.h.  */
+#ifndef EILSEQ
+#define EILSEQ ENOENT
+#endif
+
 iconv_t
 iconv_open (const char *to, const char *from)
 {


  reply	other threads:[~2009-04-13 18:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-11 19:05 Eli Zaretskii
2009-04-11 19:26 ` Pedro Alves
2009-04-11 21:27   ` Eli Zaretskii
2009-04-13 16:54     ` Tom Tromey
2009-04-13 18:52       ` Eli Zaretskii [this message]
2009-04-13 18:58         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83eivwo08j.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox