From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-62845-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12946 invoked by alias); 13 Apr 2009 18:52:00 -0000
Received: (qmail 12937 invoked by uid 22791); 13 Apr 2009 18:51:59 -0000
X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 	tests=AWL,BAYES_00,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout2.012.net.il (HELO mtaout2.012.net.il) (84.95.2.4)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 13 Apr 2009 18:51:54 +0000
Received: from conversion-daemon.i_mtaout2.012.net.il by i_mtaout2.012.net.il (HyperSendmail v2004.12) id <0KI100A00Z17GU00@i_mtaout2.012.net.il> for gdb-patches@sourceware.org; Mon, 13 Apr 2009 21:51:51 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([84.229.240.185]) by i_mtaout2.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KI100IH5Z2EODA0@i_mtaout2.012.net.il>; Mon, 13 Apr 2009 21:51:50 +0300 (IDT)
Date: Mon, 13 Apr 2009 18:52:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA] Define EILSEQ if not defined by errno.h
In-reply-to: <m363h8o5rl.fsf@fleche.redhat.com>
To: tromey@redhat.com
Cc: pedro@codesourcery.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83eivwo08j.fsf@gnu.org>
References: <83zlennh8p.fsf@gnu.org> <200904112026.46999.pedro@codesourcery.com> <83r5zyop89.fsf@gnu.org> <m363h8o5rl.fsf@fleche.redhat.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-04/txt/msg00239.txt.bz2

> Cc: Pedro Alves <pedro@codesourcery.com>, gdb-patches@sourceware.org
> From: Tom Tromey <tromey@redhat.com>
> Date: Mon, 13 Apr 2009 10:52:30 -0600
> 
> >>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
> 
> Eli> I'd like to hear Tom's opinion as well.  Tom?
> 
> I agree with all of Pedro's comments.

Thanks.  Here's what I actually committed:


2009-04-13  Eli Zaretskii  <eliz@gnu.org>

	* charset.c (EILSEQ): Define if not defined by system headers.

Index: gdb/charset.c
===================================================================
RCS file: /cvs/src/src/gdb/charset.c,v
retrieving revision 1.19
diff -u -r1.19 charset.c
--- gdb/charset.c	25 Mar 2009 00:58:34 -0000	1.19
+++ gdb/charset.c	13 Apr 2009 18:48:45 -0000
@@ -89,6 +89,15 @@
 #undef ICONV_CONST
 #define ICONV_CONST const
 
+/* Some systems, don't have EILSEQ, so we define it here, but not as
+   EINVAL, because callers of `iconv' want to distinguish EINVAL and
+   EILSEQ.  This is what iconv.h from libiconv does as well.  Note
+   that wchar.h may also define EILSEQ, so this needs to be after we
+   include wchar.h, which happens in defs.h through gdb_wchar.h.  */
+#ifndef EILSEQ
+#define EILSEQ ENOENT
+#endif
+
 iconv_t
 iconv_open (const char *to, const char *from)
 {