Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC/Patch] PR 16113: Allow gdb.Field objects as subscripts on gdb.Value objects
Date: Mon, 09 Dec 2013 03:50:00 -0000	[thread overview]
Message-ID: <83eh5mznri.fsf@gnu.org> (raw)
In-Reply-To: <CAGyQ6gyxMSf7kp940ts-B8BSRewDh9ke+0HheDS-8zkXa79Row@mail.gmail.com>

> Date: Sun, 8 Dec 2013 17:04:16 -0800
> From: Siva Chandra <sivachandra@google.com>
> 
> 2013-12-08  Siva Chandra Reddy  <sivachandra@google.com>
> 
>         PR 16113: Allow gdb.Field objects with the subscript operator on
>         gdb.Value objects of struct/class values.
>         * NEWS (Python Scripting): Add entry for the new feature.
>         * python/py-type.c (gdbpy_is_field): New function
>         * python/py-value.c (valpy_getitem): Allow subscript value to be
>         a gdb.Field object.
>         (value_has_field): New function
>         (get_field_flag): New function
>         * python/python-internal.h (gdbpy_is_field): Add declaration.
> 
>         testsuite/
>         * gdb.python/py-value-cc.cc: Improve test case.
>         * gdb.python/py-value-cc.exp: Add new tests.
> 
>         doc/
>         * gdb.texinfo (Values From Inferior): Add a note about using
>         gdb.Field objects as subscripts on gdb.Value objects.

OK for the documentation parts, but please consider adding an index
entry in the manual for the new feature.

Thanks.


  reply	other threads:[~2013-12-09  3:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-09  1:02 Siva Chandra
2013-12-09  1:04 ` Siva Chandra
2013-12-09  3:50   ` Eli Zaretskii [this message]
2013-12-09 10:30   ` Phil Muldoon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83eh5mznri.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=sivachandra@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox