From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-108113-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12724 invoked by alias); 9 Dec 2013 03:50:23 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 12712 invoked by uid 89); 9 Dec 2013 03:50:22 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout22.012.net.il
Received: from Unknown (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Dec 2013 03:50:21 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MXI00300T3I6U00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Mon, 09 Dec 2013 05:50:13 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MXI002UITBOZ760@a-mtaout22.012.net.il>; Mon, 09 Dec 2013 05:50:13 +0200 (IST)
Date: Mon, 09 Dec 2013 03:50:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFC/Patch] PR 16113: Allow gdb.Field objects as subscripts on gdb.Value objects
In-reply-to: <CAGyQ6gyxMSf7kp940ts-B8BSRewDh9ke+0HheDS-8zkXa79Row@mail.gmail.com>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83eh5mznri.fsf@gnu.org>
References: <CAGyQ6gxKWjkXGA9FXZL=_HfpBDF0q9c5vCyGq3R4nn2VnPWh0A@mail.gmail.com> <CAGyQ6gyxMSf7kp940ts-B8BSRewDh9ke+0HheDS-8zkXa79Row@mail.gmail.com>
X-IsSubscribed: yes
X-SW-Source: 2013-12/txt/msg00317.txt.bz2

> Date: Sun, 8 Dec 2013 17:04:16 -0800
> From: Siva Chandra <sivachandra@google.com>
> 
> 2013-12-08  Siva Chandra Reddy  <sivachandra@google.com>
> 
>         PR 16113: Allow gdb.Field objects with the subscript operator on
>         gdb.Value objects of struct/class values.
>         * NEWS (Python Scripting): Add entry for the new feature.
>         * python/py-type.c (gdbpy_is_field): New function
>         * python/py-value.c (valpy_getitem): Allow subscript value to be
>         a gdb.Field object.
>         (value_has_field): New function
>         (get_field_flag): New function
>         * python/python-internal.h (gdbpy_is_field): Add declaration.
> 
>         testsuite/
>         * gdb.python/py-value-cc.cc: Improve test case.
>         * gdb.python/py-value-cc.exp: Add new tests.
> 
>         doc/
>         * gdb.texinfo (Values From Inferior): Add a note about using
>         gdb.Field objects as subscripts on gdb.Value objects.

OK for the documentation parts, but please consider adding an index
entry in the manual for the new feature.

Thanks.