From: Eli Zaretskii <eliz@gnu.org>
To: Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
Cc: gdb-patches@sourceware.org, uweigand@de.ibm.com, edjunior@gmail.com
Subject: Re: [PATCH v2 09/12] [PowerPC] Add support for TAR
Date: Fri, 10 Aug 2018 07:32:00 -0000 [thread overview]
Message-ID: <83eff6oex7.fsf@gnu.org> (raw)
In-Reply-To: <20180810025210.6942-10-pedromfc@linux.ibm.com> (message from Pedro Franco de Carvalho on Thu, 9 Aug 2018 23:52:07 -0300)
> From: Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
> Cc: uweigand@de.ibm.com, edjunior@gmail.com
> Date: Thu, 9 Aug 2018 23:52:07 -0300
>
> From: Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
>
> This patch adds support for the Target Address Register for powerpc
> linux native and core file targets, and in the powerpc linux server
> stub.
>
> gdb/ChangeLog:
> YYYY-MM-DD Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
> Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
>
> * arch/ppc-linux-tdesc.h (tdesc_powerpc_isa207_vsx32l)
> (tdesc_powerpc_isa207_vsx64l): Declare.
> * arch/ppc-linux-common.h (PPC_LINUX_SIZEOF_TARREGSET): Define.
> (struct ppc_linux_features) <isa207>: New field.
> (ppc_linux_no_features): Add initializer for isa207 field.
> * arch/ppc-linux-common.c (ppc_linux_match_description): Return
> new tdescs.
> * nat/ppc-linux.h (PPC_FEATURE2_ARCH_2_07, PPC_FEATURE2_TAR)
> (NT_PPC_TAR): Define if not already defined.
> * features/Makefile (WHICH): Add rs6000/powerpc-isa207-vsx32l and
> rs6000/powerpc-isa207-vsx64l.
> (XMLTOC): Add rs6000/powerpc-isa207-vsx32l.xml and
> rs6000/powerpc-isa207-vsx64l.xml.
> * features/rs6000/power-tar.xml: New file.
> * features/rs6000/powerpc-isa207-vsx32l.xml: New file.
> * features/rs6000/powerpc-isa207-vsx64l.xml: New file.
> * features/rs6000/powerpc-isa207-vsx32l.c: Generate.
> * features/rs6000/powerpc-isa207-vsx64l.c: Generate.
> * regformats/rs6000/powerpc-isa207-vsx32l.dat: Generate.
> * regformats/rs6000/powerpc-isa207-vsx64l.dat: Generate.
> * ppc-linux-nat.c (fetch_register, fetch_ppc_registers): Call
> fetch_regset with the TAR regset.
> (store_register, store_ppc_registers): Call store_regset with the
> TAR regset.
> (ppc_linux_nat_target::read_description): Set isa207 field in the
> features struct if needed.
> * ppc-linux-tdep.c: Include
> features/rs6000/powerpc-isa207-vsx32l.c and
> features/rs6000/powerpc-isa207-vsx64l.c.
> (ppc32_regmap_tar, ppc32_linux_tarregset): New globals.
> (ppc_linux_iterate_over_regset_sections): Call back with the tar
> regset.
> (ppc_linux_core_read_description): Check if the tar section is
> present and set isa207 in the features struct.
> (_initialize_ppc_linux_tdep): Call
> initialize_tdesc_powerpc_isa207_vsx32l and
> initialize_tdesc_powerpc_isa207_vsx64l.
> * ppc-linux-tdep.h (ppc32_linux_tarregset): Declare.
> * ppc-tdep.h (gdbarch_tdep) <ppc_tar_regnum>: New field.
> (enum) <PPC_TAR_REGNUM>: New enum value.
> * rs6000-tdep.c (rs6000_gdbarch_init): Look for and validate tar
> feature.
> (ppc_process_record_op31): Record changes to TAR.
>
> gdb/gdbserver/ChangeLog:
> YYYY-MM-DD Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
>
> * configure.srv (ipa_ppc_linux_regobj): Add
> powerpc-isa207-vsx64l-ipa.o and powerpc-isa207-vsx32l-ipa.o.
> (powerpc*-*-linux*): Add powerpc-isa207-vsx32l.o and
> powerpc-isa207-vsx64l.o to srv_regobj, add rs6000/power-tar.xml,
> rs6000/powerpc-isa207-vsx32l.xml, and
> rs6000/powerpc-isa207-vsx64l.xml to srv_xmlfiles.
> * linux-ppc-tdesc-init.h (enum ppc_linux_tdesc)
> <PPC_TDESC_ISA207_VSX>: New enum value.
> (init_registers_powerpc_isa207_vsx32l): Declare.
> (init_registers_powerpc_isa207_vsx64l): Declare.
> * linux-ppc-low.c (ppc_fill_tarregset): New function.
> (ppc_store_tarregset): New function.
> (ppc_regsets): Add entry for the TAR regset.
> (ppc_arch_setup): Set isa207 in features struct when needed. Set
> size for the TAR regsets.
> (ppc_get_ipa_tdesc_idx): Return PPC_TDESC_ISA207_VSX.
> (initialize_low_arch): Call init_registers_powerpc_isa207_vsx32l
> and init_registers_powerpc_isa207_vsx64l.
> * linux-ppc-ipa.c (get_ipa_tdesc): Handle PPC_TDESC_ISA207_VSX.
> (initialize_low_tracepoint): Call
> init_registers_powerpc_isa207_vsx32l and
> init_registers_powerpc_isa207_vsx64l.
>
> gdb/testsuite/ChangeLog:
> YYYY-MM-DD Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
>
> * gdb.arch/powerpc-tar.c: New file.
> * gdb.arch/powerpc-tar.exp: New file.
>
> gdb/doc/ChangeLog:
> YYYY-MM-DD Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
>
> * gdb.texinfo (PowerPC Features): Describe new feature
> "org.gnu.gdb.power.tar".
OK for the gdb.texinfo part.
Thanks.
next prev parent reply other threads:[~2018-08-10 7:32 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-10 2:52 [PATCH v2 00/12] GDB support for more powerpc registers on linux Pedro Franco de Carvalho
2018-08-10 2:52 ` [PATCH v2 04/12] [PowerPC] Remove rs6000_pseudo_register_reggroup_p Pedro Franco de Carvalho
2018-08-10 14:33 ` Ulrich Weigand
2018-08-10 2:52 ` [PATCH v2 08/12] [PowerPC] Add support for PPR and DSCR Pedro Franco de Carvalho
2018-08-10 14:39 ` Ulrich Weigand
2018-08-10 19:38 ` Pedro Alves
2018-08-10 20:09 ` Pedro Franco de Carvalho
2018-08-13 16:30 ` Pedro Alves
2018-08-14 20:15 ` Pedro Franco de Carvalho
2018-08-10 2:52 ` [PATCH v2 05/12] [PowerPC] Fix two if statements in gdb/ppc-linux-nat.c Pedro Franco de Carvalho
2018-08-10 14:33 ` Ulrich Weigand
2018-08-10 2:52 ` [PATCH v2 01/12] Zero-initialize linux note sections Pedro Franco de Carvalho
2018-08-10 14:27 ` Ulrich Weigand
2018-08-10 16:13 ` Tom Tromey
2018-08-10 18:11 ` Pedro Franco de Carvalho
2018-08-10 20:50 ` Tom Tromey
2018-08-10 2:52 ` [PATCH v2 11/12] [PowerPC] Reject tdescs with VSX and no FPU or Altivec Pedro Franco de Carvalho
2018-08-10 14:44 ` Ulrich Weigand
2018-08-10 2:52 ` [PATCH v2 06/12] [PowerPC] Fix indentation in arch/ppc-linux-common.c Pedro Franco de Carvalho
2018-08-10 14:34 ` Ulrich Weigand
2018-08-10 2:52 ` [PATCH v2 12/12] [PowerPC] Add support for HTM registers Pedro Franco de Carvalho
2018-08-10 7:34 ` Eli Zaretskii
2018-08-10 14:54 ` Ulrich Weigand
2018-08-10 15:12 ` [PATCH v2] " Pedro Franco de Carvalho
2018-08-10 2:52 ` [PATCH v2 03/12] Add decfloat registers to float reggroup Pedro Franco de Carvalho
2018-08-10 14:35 ` Ulrich Weigand
2018-08-10 2:52 ` [PATCH v2 09/12] [PowerPC] Add support for TAR Pedro Franco de Carvalho
2018-08-10 7:32 ` Eli Zaretskii [this message]
2018-08-10 18:12 ` Pedro Franco de Carvalho
2018-08-10 14:41 ` Ulrich Weigand
2018-08-10 2:52 ` [PATCH v2 07/12] [PowerPC] Refactor have_ initializers in rs6000-tdep.c Pedro Franco de Carvalho
2018-08-10 14:34 ` Ulrich Weigand
2018-08-10 2:52 ` [PATCH v2 02/12] [PowerPC] Don't zero-initialize vector register buffers Pedro Franco de Carvalho
2018-08-10 14:30 ` Ulrich Weigand
2018-08-10 3:19 ` [PATCH v2 10/12] [PowerPC] Add support for EBB and PMU registers Pedro Franco de Carvalho
2018-08-10 7:35 ` Eli Zaretskii
2018-08-10 14:44 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83eff6oex7.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=edjunior@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=pedromfc@linux.ibm.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox