Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: pedromfc@linux.ibm.com (Pedro Franco de Carvalho)
Cc: gdb-patches@sourceware.org, edjunior@gmail.com
Subject: Re: [PATCH v2 08/12] [PowerPC] Add support for PPR and DSCR
Date: Fri, 10 Aug 2018 14:39:00 -0000	[thread overview]
Message-ID: <20180810143903.38392D802AC@oc3748833570.ibm.com> (raw)
In-Reply-To: <20180810025210.6942-9-pedromfc@linux.ibm.com> from "Pedro Franco de Carvalho" at Aug 09, 2018 11:52:06 PM

Pedro Franco de Carvalho wrote:

> gdb/ChangeLog:
> YYYY-MM-DD  Edjunior Barbosa Machado  <emachado@linux.vnet.ibm.com>
> 	    Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
> 
> 	* arch/ppc-linux-tdesc.h (tdesc_powerpc_isa205_ppr_dscr_vsx32l)
> 	(tdesc_powerpc_isa205_ppr_dscr_vsx64l): Declare.
> 	* arch/ppc-linux-common.h (PPC_LINUX_SIZEOF_PPRREGSET)
> 	(PPC_LINUX_SIZEOF_DSCRREGSET): Define.
> 	(struct ppc_linux_features) <ppr_dscr>: New field.
> 	(ppc_linux_no_features): Add initializer for ppr_dscr field.
> 	* arch/ppc-linux-common.c (ppc_linux_match_description): Return
> 	new tdescs.
> 	* nat/ppc-linux.h (PPC_FEATURE2_DSCR, NT_PPC_PPR, NT_PPC_DSCR):
> 	Define if not already defined.
> 	* features/Makefile (WHICH): Add
> 	rs6000/powerpc-isa205-ppr-dscr-vsx32l and
> 	rs6000/powerpc-isa205-ppr-dscr-vsx64l.
> 	(XMLTOC): Add rs6000/powerpc-isa205-ppr-dscr-vsx32l.xml and
> 	rs6000/powerpc-isa205-ppr-dscr-vsx64l.xml.
> 	* features/rs6000/power-dscr.xml: New file.
> 	* features/rs6000/power-ppr.xml: New file.
> 	* features/rs6000/powerpc-isa205-ppr-dscr-vsx32l.xml: New file.
> 	* features/rs6000/powerpc-isa205-ppr-dscr-vsx64l.xml: New file.
> 	* features/rs6000/powerpc-isa205-ppr-dscr-vsx32l.c: Generate.
> 	* features/rs6000/powerpc-isa205-ppr-dscr-vsx64l.c: Generate.
> 	* regformats/rs6000/powerpc-isa205-ppr-dscr-vsx32l.dat: Generate.
> 	* regformats/rs6000/powerpc-isa205-ppr-dscr-vsx64l.dat: Generate.
> 	* ppc-linux-nat.c: Include <sys/uio.h>.
> 	(fetch_regset, store_regset, check_regset): New functions.
> 	(fetch_register, fetch_ppc_registers): Call fetch_regset with
> 	DSCR and PPR regsets.
> 	(store_register, store_ppc_registers): Call store_regset with
> 	DSCR and PPR regsets.
> 	(ppc_linux_get_hwcap2): New function.
> 	(ppc_linux_nat_target::read_description): Call
> 	ppc_linux_get_hwcap2 and check_regset, set ppr_dscr field in the
> 	features struct if needed.
> 	* ppc-linux-tdep.c: Include
> 	features/rs6000/powerpc-isa205-ppr-dscr-vsx32l.c and
> 	features/rs6000/powerpc-isa205-ppr-dscr-vsx64l.c.
> 	(ppc32_regmap_ppr, ppc32_regmap_dscr, ppc32_linux_pprregset)
> 	(ppc32_linux_dscrregset): New globals.
> 	(ppc_linux_iterate_over_regset_sections): Call back with the ppr
> 	and dscr regsets.
> 	(ppc_linux_core_read_description): Check if the ppr and dscr
> 	sections are present and set ppr_dscr in the features struct.
> 	(_initialize_ppc_linux_tdep): Call
> 	initialize_tdesc_powerpc_isa205_ppr_dscr_vsx32l and
> 	initialize_tdesc_powerpc_isa205_ppr_dscr_vsx64l.
> 	* ppc-linux-tdep.h (ppc32_linux_pprregset)
> 	(ppc32_linux_dscrregset): Declare.
> 	* ppc-tdep.h (struct gdbarch_tdep) <ppc_ppr_regnum>: New field.
> 	<ppc_dscr_regnum>: New field.
> 	(enum) <PPC_PPR_REGNUM, PPC_DSCR_REGNUM>: New enum values.
> 	* rs6000-tdep.c (rs6000_gdbarch_init): Look for and validate ppr
> 	and dscr features.
> 	(ppc_process_record_op31): Record changes to PPR and DSCR.
> 
> gdb/gdbserver/ChangeLog:
> YYYY-MM-DD  Edjunior Barbosa Machado  <emachado@linux.vnet.ibm.com>
> 	    Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
> 
> 	* configure.srv (ipa_ppc_linux_regobj): Add
> 	powerpc-isa205-ppr-dscr-vsx32l-ipa.o and
> 	powerpc-isa205-ppr-dscr-vsx64l-ipa.o.
> 	(powerpc*-*-linux*): Add powerpc-isa205-ppr-dscr-vsx32l.o and
> 	powerpc-isa205-ppr-dscr-vsx64l.o to srv_regobj, add
> 	rs6000/power-dscr.xml, rs6000/power-ppr.xml,
> 	rs6000/powerpc-isa205-ppr-dscr-vsx32l.xml and
> 	rs6000/powerpc-isa205-ppr-dscr-vsx64l.xml to srv_xmlfiles.
> 	* linux-ppc-tdesc-init.h (enum ppc_linux_tdesc)
> 	<PPC_TDESC_ISA205_PPR_DSCR_VSX>: New enum value.
> 	(init_registers_powerpc_isa205_ppr_dscr_vsx32l)
> 	(init_registers_powerpc_isa205_ppr_dscr_vsx64l): Declare.
> 	* linux-ppc-low.c: Include "elf/common.h" and <sys/uio.h>.
> 	(ppc_hwcap2): New global.
> 	(ppc_check_regset, ppc_fill_pprregset, ppc_store_pprregset)
> 	(ppc_fill_dscrregset, ppc_store_dscrregset): New functions.
> 	(ppc_regsets): Add entries for the DSCR and PPR regsets.
> 	(ppc_arch_setup): Get AT_HWCAP2.  Set ppr_dscr in features struct
> 	when needed.  Set sizes for the the DSCR and PPR regsets.
> 	(ppc_get_ipa_tdesc_idx): Return PPC_TDESC_ISA205_PPR_DSCR_VSX.
> 	(initialize_low_arch): Call
> 	init_registers_powerpc_isa205_ppr_dscr_vsx32l and
> 	init_registers_powerpc_isa205_ppr_dscr_vsx64l.
> 	* linux-ppc-ipa.c (get_ipa_tdesc): Handle
> 	PPC_TDESC_ISA205_PPR_DSCR_VSX.
> 	(initialize_low_tracepoint): Call
> 	init_registers_powerpc_isa205_ppr_dscr_vsx32l and
> 	init_registers_powerpc_isa205_ppr_dscr_vsx64l.
> 
> gdb/testsuite/ChangeLog:
> YYYY-MM-DD  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
> 
> 	* gdb.arch/powerpc-ppr-dscr.c: New file.
> 	* gdb.arch/powerpc-ppr-dscr.exp: New file.
> 
> gdb/doc/ChangeLog:
> YYYY-MM-DD  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
> 
> 	* gdb.texinfo (PowerPC Features): Describe new features
> 	"org.gnu.gdb.power.ppr" and "org.gnu.gdb.power.dscr".

This is OK.

Thanks,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU/Linux compilers and toolchain
  Ulrich.Weigand@de.ibm.com


  reply	other threads:[~2018-08-10 14:39 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-10  2:52 [PATCH v2 00/12] GDB support for more powerpc registers on linux Pedro Franco de Carvalho
2018-08-10  2:52 ` [PATCH v2 06/12] [PowerPC] Fix indentation in arch/ppc-linux-common.c Pedro Franco de Carvalho
2018-08-10 14:34   ` Ulrich Weigand
2018-08-10  2:52 ` [PATCH v2 11/12] [PowerPC] Reject tdescs with VSX and no FPU or Altivec Pedro Franco de Carvalho
2018-08-10 14:44   ` Ulrich Weigand
2018-08-10  2:52 ` [PATCH v2 07/12] [PowerPC] Refactor have_ initializers in rs6000-tdep.c Pedro Franco de Carvalho
2018-08-10 14:34   ` Ulrich Weigand
2018-08-10  2:52 ` [PATCH v2 02/12] [PowerPC] Don't zero-initialize vector register buffers Pedro Franco de Carvalho
2018-08-10 14:30   ` Ulrich Weigand
2018-08-10  2:52 ` [PATCH v2 12/12] [PowerPC] Add support for HTM registers Pedro Franco de Carvalho
2018-08-10  7:34   ` Eli Zaretskii
2018-08-10 14:54   ` Ulrich Weigand
2018-08-10 15:12     ` [PATCH v2] " Pedro Franco de Carvalho
2018-08-10  2:52 ` [PATCH v2 09/12] [PowerPC] Add support for TAR Pedro Franco de Carvalho
2018-08-10  7:32   ` Eli Zaretskii
2018-08-10 18:12     ` Pedro Franco de Carvalho
2018-08-10 14:41   ` Ulrich Weigand
2018-08-10  2:52 ` [PATCH v2 03/12] Add decfloat registers to float reggroup Pedro Franco de Carvalho
2018-08-10 14:35   ` Ulrich Weigand
2018-08-10  2:52 ` [PATCH v2 05/12] [PowerPC] Fix two if statements in gdb/ppc-linux-nat.c Pedro Franco de Carvalho
2018-08-10 14:33   ` Ulrich Weigand
2018-08-10  2:52 ` [PATCH v2 04/12] [PowerPC] Remove rs6000_pseudo_register_reggroup_p Pedro Franco de Carvalho
2018-08-10 14:33   ` Ulrich Weigand
2018-08-10  2:52 ` [PATCH v2 08/12] [PowerPC] Add support for PPR and DSCR Pedro Franco de Carvalho
2018-08-10 14:39   ` Ulrich Weigand [this message]
2018-08-10 19:38   ` Pedro Alves
2018-08-10 20:09     ` Pedro Franco de Carvalho
2018-08-13 16:30       ` Pedro Alves
2018-08-14 20:15         ` Pedro Franco de Carvalho
2018-08-10  2:52 ` [PATCH v2 01/12] Zero-initialize linux note sections Pedro Franco de Carvalho
2018-08-10 14:27   ` Ulrich Weigand
2018-08-10 16:13   ` Tom Tromey
2018-08-10 18:11     ` Pedro Franco de Carvalho
2018-08-10 20:50       ` Tom Tromey
2018-08-10  3:19 ` [PATCH v2 10/12] [PowerPC] Add support for EBB and PMU registers Pedro Franco de Carvalho
2018-08-10  7:35   ` Eli Zaretskii
2018-08-10 14:44   ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180810143903.38392D802AC@oc3748833570.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=edjunior@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedromfc@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox