Re: [PATCH] Fast tracepoints

[Eli Zaretskii <eliz@gnu.org>]

> Date: Mon, 04 Jan 2010 18:38:32 -0800
> From: Stan Shebs <stan@codesourcery.com>
> 
> This patch adds "fast" tracepoints to GDB.

Thanks.

> Index: NEWS
> ===================================================================
> RCS file: /cvs/src/src/gdb/NEWS,v
> retrieving revision 1.344
> diff -p -r1.344 NEWS
> *** NEWS	31 Dec 2009 17:47:42 -0000	1.344
> --- NEWS	5 Jan 2010 02:13:28 -0000

This part is OK, but please give me 2 spaces between sentences.

> *** doc/gdb.texinfo	1 Jan 2010 07:54:37 -0000	1.654
> --- doc/gdb.texinfo	5 Jan 2010 02:13:29 -0000

A few comments for this part:

> + Some targets may support @dfn{fast tracepoints}, which are inserted in
> + a different way (such as with a jump instead of a trap), that is
> + faster but possibly restricted in where they may be installed.

Please put the "@cindex fast tracepoints" entry here, not 50 lines
below.

> + The @code{ftrace} command sets a fast tracepoint.  For targets that
> + support it, fast tracepoints will use a more efficient but possibly

"For targets that support them, fast tracepoints will use ..."

Okay with those changes.