From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-69263-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31885 invoked by alias); 5 Jan 2010 20:07:47 -0000
Received: (qmail 31876 invoked by uid 22791); 5 Jan 2010 20:07:46 -0000
X-SWARE-Spam-Status: No, hits=-1.0 required=5.0 	tests=AWL,BAYES_00,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Jan 2010 20:07:42 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0KVS00G00IGE9P00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Tue, 05 Jan 2010 22:07:39 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.127.222.44]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KVS009XFIKPSCZ0@a-mtaout20.012.net.il>; Tue, 05 Jan 2010 22:07:38 +0200 (IST)
Date: Tue, 05 Jan 2010 20:07:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] Fast tracepoints
In-reply-to: <4B42A628.5060302@codesourcery.com>
To: Stan Shebs <stan@codesourcery.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83d41oco6k.fsf@gnu.org>
References: <4B42A628.5060302@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-01/txt/msg00087.txt.bz2

> Date: Mon, 04 Jan 2010 18:38:32 -0800
> From: Stan Shebs <stan@codesourcery.com>
> 
> This patch adds "fast" tracepoints to GDB.

Thanks.

> Index: NEWS
> ===================================================================
> RCS file: /cvs/src/src/gdb/NEWS,v
> retrieving revision 1.344
> diff -p -r1.344 NEWS
> *** NEWS	31 Dec 2009 17:47:42 -0000	1.344
> --- NEWS	5 Jan 2010 02:13:28 -0000

This part is OK, but please give me 2 spaces between sentences.

> *** doc/gdb.texinfo	1 Jan 2010 07:54:37 -0000	1.654
> --- doc/gdb.texinfo	5 Jan 2010 02:13:29 -0000

A few comments for this part:

> + Some targets may support @dfn{fast tracepoints}, which are inserted in
> + a different way (such as with a jump instead of a trap), that is
> + faster but possibly restricted in where they may be installed.

Please put the "@cindex fast tracepoints" entry here, not 50 lines
below.

> + The @code{ftrace} command sets a fast tracepoint.  For targets that
> + support it, fast tracepoints will use a more efficient but possibly

"For targets that support them, fast tracepoints will use ..."

Okay with those changes.