Re: [PATCH] Fix ptype/o bug with "<no data fields>"

[Eli Zaretskii via Gdb-patches <gdb-patches@sourceware.org>]

> Date: Fri, 23 Apr 2021 11:41:53 +0100
> From: Lancelot SIX <lsix@lancelotsix.com>
> Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
> 
> The patch that needs to be reviewed for the documentation part it this
> one: https://sourceware.org/pipermail/gdb-patches/2021-April/177843.html

Thanks, see below:

> +When @value{GDBN} prints sizes and offsets of struct members, decimal or
> +hexadecimal notations can be used.  Selecting one or the other can be
> +done either by passing the appropriate flag to @code{ptype}, or by using
> +@command{set print type hex}.

This uses the passive tense too much, and thus is awkward to read.
Suggest to rephrase:

  When @value{GDBN} prints sizes and offsets of struct members, it can
  use either the decimal or hexadecimal notation.  You can select one or
  the other either by passing the appropriate flag to @code{ptype}, or
  by using the @command{set print type hex} command.

> +@item show print type hex
> +This command show the current setting used to configure whether decimal or
> +hexadecimal notation should be used when printing sized and offsets of
> +struct members.

"shows", singular.  But I'd also suggest slight rewording to make the
text simpler:

  This command shows whether the sizes and offsets of struct members
  are printed in decimal or hexadecimal notation.

> +			   _("Show printing of struct members sizes and offsets \
> +			     using hex notation."), nullptr,

I think

 Show whether sizes and offsets of struct members are printed
 using hex notation.

is better.

Thanks.