From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id IahBEHupgmD/dwAAWB0awg (envelope-from ) for ; Fri, 23 Apr 2021 07:03:23 -0400 Received: by simark.ca (Postfix, from userid 112) id 2FB831F104; Fri, 23 Apr 2021 07:03:23 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 731B11E789 for ; Fri, 23 Apr 2021 07:03:22 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CECA43A78006; Fri, 23 Apr 2021 11:03:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CECA43A78006 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619175801; bh=vOSDCpF0otQuqeG60rh+oN+2BvEPOITx4IkSlSY50RA=; h=Date:To:In-Reply-To:Subject:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=YWrBaYQ/XnDQmDRjp7iTY4w3ye1pdiqZvDIcGOnfbM8UTGj4Bz37ia5cIccVkzkcH kpgoekQ1tNql6Br7eE642vUp88yXkdeS4LOC8qImzm39wMA2o8aPGbMxzFew2wZlSL A1WA3Km2jwVB9GB5+6H424wqXYo/yVe07IUdCMys= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id E26DC3A78006 for ; Fri, 23 Apr 2021 11:03:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E26DC3A78006 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45359) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZtag-0005vs-9x; Fri, 23 Apr 2021 07:03:18 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3369 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lZtad-0007iZ-3Y; Fri, 23 Apr 2021 07:03:16 -0400 Date: Fri, 23 Apr 2021 14:03:06 +0300 Message-Id: <83czulntzp.fsf@gnu.org> To: Lancelot SIX In-Reply-To: <20210423104153.77hotw6yvek2lt4p@Plymouth> (message from Lancelot SIX on Fri, 23 Apr 2021 11:41:53 +0100) Subject: Re: [PATCH] Fix ptype/o bug with "" References: <20210422014904.3521301-1-tom@tromey.com> <20210422093100.GM2610@embecosm.com> <87zgxq8nmr.fsf@tromey.com> <20210422214553.pkvxsgnotuftuwgt@Plymouth> <87czulg4os.fsf@tromey.com> <83r1j1o7fi.fsf@gnu.org> <20210423104153.77hotw6yvek2lt4p@Plymouth> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Cc: tom@tromey.com, gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > Date: Fri, 23 Apr 2021 11:41:53 +0100 > From: Lancelot SIX > Cc: Tom Tromey , gdb-patches@sourceware.org > > The patch that needs to be reviewed for the documentation part it this > one: https://sourceware.org/pipermail/gdb-patches/2021-April/177843.html Thanks, see below: > +When @value{GDBN} prints sizes and offsets of struct members, decimal or > +hexadecimal notations can be used. Selecting one or the other can be > +done either by passing the appropriate flag to @code{ptype}, or by using > +@command{set print type hex}. This uses the passive tense too much, and thus is awkward to read. Suggest to rephrase: When @value{GDBN} prints sizes and offsets of struct members, it can use either the decimal or hexadecimal notation. You can select one or the other either by passing the appropriate flag to @code{ptype}, or by using the @command{set print type hex} command. > +@item show print type hex > +This command show the current setting used to configure whether decimal or > +hexadecimal notation should be used when printing sized and offsets of > +struct members. "shows", singular. But I'd also suggest slight rewording to make the text simpler: This command shows whether the sizes and offsets of struct members are printed in decimal or hexadecimal notation. > + _("Show printing of struct members sizes and offsets \ > + using hex notation."), nullptr, I think Show whether sizes and offsets of struct members are printed using hex notation. is better. Thanks.