* [patch/RFA] coffcode.h needs to include libiberty.h
@ 2009-09-05 15:53 Eli Zaretskii
2009-09-05 16:07 ` Joel Brobecker
0 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2009-09-05 15:53 UTC (permalink / raw)
To: binutils, gdb-patches
The following patch is needed to prevent compiler warnings during the
DJGPP build of GDB. DJGPP does not have snprintf in its library and
headers, and uses the libiberty version, so the compiler complains
about its implicit declaration.
If this patch is okay, please somebody commit it, as I don't have
write access to the BFD repository.
Thanks.
2009-09-05 Eli Zaretskii <eliz@gnu.org>
* coffcode.h: Include libiberty.h.
--- bfd/coffcode.h~0 2009-08-11 00:56:42.000000000 +0300
+++ bfd/coffcode.h 2009-09-05 16:41:25.953125000 +0300
@@ -361,6 +361,8 @@
*/
+#include "libiberty.h"
+
#ifdef COFF_WITH_PE
#include "peicode.h"
#else
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch/RFA] coffcode.h needs to include libiberty.h
2009-09-05 15:53 [patch/RFA] coffcode.h needs to include libiberty.h Eli Zaretskii
@ 2009-09-05 16:07 ` Joel Brobecker
2009-09-05 16:18 ` Eli Zaretskii
0 siblings, 1 reply; 5+ messages in thread
From: Joel Brobecker @ 2009-09-05 16:07 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: binutils, gdb-patches
> If this patch is okay, please somebody commit it, as I don't have
> write access to the BFD repository.
IFAIK, it's the same as the GDB repository, so you should be able
to commit your change.
--
Joel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch/RFA] coffcode.h needs to include libiberty.h
2009-09-05 16:07 ` Joel Brobecker
@ 2009-09-05 16:18 ` Eli Zaretskii
2009-09-05 16:26 ` Dave Korn
0 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2009-09-05 16:18 UTC (permalink / raw)
To: Joel Brobecker; +Cc: binutils, gdb-patches
> Date: Sat, 5 Sep 2009 09:07:47 -0700
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: binutils@sourceware.org, gdb-patches@sourceware.org
>
> > If this patch is okay, please somebody commit it, as I don't have
> > write access to the BFD repository.
>
> IFAIK, it's the same as the GDB repository, so you should be able
> to commit your change.
OK, waiting for approval, then.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch/RFA] coffcode.h needs to include libiberty.h
2009-09-05 16:18 ` Eli Zaretskii
@ 2009-09-05 16:26 ` Dave Korn
2009-09-05 16:40 ` Eli Zaretskii
0 siblings, 1 reply; 5+ messages in thread
From: Dave Korn @ 2009-09-05 16:26 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: Joel Brobecker, binutils, gdb-patches
Eli Zaretskii wrote:
> OK, waiting for approval, then.
This is OK. Please go ahead.
cheers,
DaveK
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [patch/RFA] coffcode.h needs to include libiberty.h
2009-09-05 16:26 ` Dave Korn
@ 2009-09-05 16:40 ` Eli Zaretskii
0 siblings, 0 replies; 5+ messages in thread
From: Eli Zaretskii @ 2009-09-05 16:40 UTC (permalink / raw)
To: Dave Korn; +Cc: brobecker, binutils, gdb-patches
> Date: Sat, 05 Sep 2009 17:40:02 +0100
> From: Dave Korn <dave.korn.cygwin@googlemail.com>
> CC: Joel Brobecker <brobecker@adacore.com>, binutils@sourceware.org,
> gdb-patches@sourceware.org
>
> Eli Zaretskii wrote:
>
> > OK, waiting for approval, then.
>
> This is OK. Please go ahead.
Thanks, committed.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-09-05 16:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-09-05 15:53 [patch/RFA] coffcode.h needs to include libiberty.h Eli Zaretskii
2009-09-05 16:07 ` Joel Brobecker
2009-09-05 16:18 ` Eli Zaretskii
2009-09-05 16:26 ` Dave Korn
2009-09-05 16:40 ` Eli Zaretskii
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox