Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Koning <paulkoning@comcast.net>
Cc: gdb-patches@sourceware.org, tromey@redhat.com, raise.sail@gmail.com
Subject: Re: [RFA] Python: iterator for deep traversal of gdb.Type struct/union fields
Date: Tue, 25 Oct 2011 20:16:00 -0000	[thread overview]
Message-ID: <83bot4de4v.fsf@gnu.org> (raw)
In-Reply-To: <4C0389F5-A2DF-4864-8E33-BB893C885C98@comcast.net>

> From: Paul Koning <paulkoning@comcast.net>
> Date: Tue, 25 Oct 2011 14:54:21 -0400
> Cc: Tom Tromey <tromey@redhat.com>, Li Yu <raise.sail@gmail.com>
> 
> +@item deepitems (@var{type})
> +Returns a Python iterator similar to the standard
> +@code{gdb.Type.iteritems ()} method, except that the iterator returned
                            ^^
Please lose the parentheses.  You just want the method's name, and you
already say that it's a method.  So the parentheses don't add anything
except potential confusion.

> +@end smallexample
> +
> +Then in gdb:

You want @noindent before "Then in gdb", to make it look like
continuation of the previous paragraph, not a beginning of a new one.

Also, please use @value{GDBN} instead of a literal "gdb".

> +(gdb) python import gdb.types

We use @value{GDBP} instead of a literal "(gdb)".

OK with those changes.

Thanks.


  reply	other threads:[~2011-10-25 20:13 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-30 11:04 [PATCH v2] gdb/python: add missing handling for anonymous members of struct and union Li Yu
2011-09-30 16:15 ` Paul Koning
2011-10-01 14:01   ` Li Yu
2011-10-01 18:54     ` Paul Koning
2011-10-04 16:37 ` Tom Tromey
2011-10-04 18:05   ` Paul Koning
2011-10-04 20:24     ` Tom Tromey
2011-10-04 20:41       ` Paul Koning
2011-10-19 20:52         ` Tom Tromey
2011-10-19 20:59           ` Paul Koning
2011-10-20 18:49             ` Tom Tromey
2011-10-25 18:34               ` [RFA] Python: iterator for deep traversal of gdb.Type struct/union fields Paul Koning
2011-10-25 19:03                 ` Paul Koning
2011-10-25 20:16                   ` Eli Zaretskii [this message]
2011-10-26 17:14                     ` Paul Koning
2011-10-27 13:01                       ` Doug Evans
2011-10-27 14:52                         ` Paul_Koning
2011-10-27 19:57                           ` Tom Tromey
     [not found]                             ` <09787EF419216C41A903FD14EE5506DD030CF168FB@AUSX7MCPC103.AMER.DELL.COM>
2011-10-27 21:56                               ` Paul Koning
2011-10-27 22:14                                 ` Eli Zaretskii
2011-10-28 14:55                                   ` Paul Koning

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83bot4de4v.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=paulkoning@comcast.net \
    --cc=raise.sail@gmail.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox