From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-84678-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 21842 invoked by alias); 25 Oct 2011 20:13:18 -0000
Received: (qmail 21823 invoked by uid 22791); 25 Oct 2011 20:13:16 -0000
X-SWARE-Spam-Status: No, hits=-0.8 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_WEB,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 25 Oct 2011 20:13:01 +0000
Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0LTN00G001BYT400@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Tue, 25 Oct 2011 22:12:33 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.124.212.197]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LTN00GMR1GPSK20@a-mtaout23.012.net.il>; Tue, 25 Oct 2011 22:12:26 +0200 (IST)
Date: Tue, 25 Oct 2011 20:16:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA] Python: iterator for deep traversal of gdb.Type struct/union fields
In-reply-to: <4C0389F5-A2DF-4864-8E33-BB893C885C98@comcast.net>
To: Paul Koning <paulkoning@comcast.net>
Cc: gdb-patches@sourceware.org, tromey@redhat.com, raise.sail@gmail.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83bot4de4v.fsf@gnu.org>
References: <4E8595F6.7080004@gmail.com> <m38vp0pvc9.fsf@fleche.redhat.com> <ABB9CE3B-04DC-4EA9-A25A-F3590025AB5C@comcast.net> <m3pqicld48.fsf@fleche.redhat.com> <F281C53B-182F-44BA-B0DB-C0E46E47069F@comcast.net> <m3mxcwso51.fsf@fleche.redhat.com> <2460DAAE-C437-469A-BA1A-47343C5DBB45@comcast.net> <m3sjmnpqoy.fsf@fleche.redhat.com> <4E8F0244-3A3F-4AE2-A13C-DA9503282A97@comcast.net> <4C0389F5-A2DF-4864-8E33-BB893C885C98@comcast.net>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-10/txt/msg00681.txt.bz2

> From: Paul Koning <paulkoning@comcast.net>
> Date: Tue, 25 Oct 2011 14:54:21 -0400
> Cc: Tom Tromey <tromey@redhat.com>, Li Yu <raise.sail@gmail.com>
> 
> +@item deepitems (@var{type})
> +Returns a Python iterator similar to the standard
> +@code{gdb.Type.iteritems ()} method, except that the iterator returned
                            ^^
Please lose the parentheses.  You just want the method's name, and you
already say that it's a method.  So the parentheses don't add anything
except potential confusion.

> +@end smallexample
> +
> +Then in gdb:

You want @noindent before "Then in gdb", to make it look like
continuation of the previous paragraph, not a beginning of a new one.

Also, please use @value{GDBN} instead of a literal "gdb".

> +(gdb) python import gdb.types

We use @value{GDBP} instead of a literal "(gdb)".

OK with those changes.

Thanks.