Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org, pmuldoon@redhat.com
Subject: Re: [PATCH v2 7/9] compile: New 'compile print'
Date: Mon, 06 Apr 2015 17:41:00 -0000	[thread overview]
Message-ID: <83bnj1jgsw.fsf@gnu.org> (raw)
In-Reply-To: <20150406172716.31404.8551.stgit@host1.jankratochvil.net>

> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Cc: Phil Muldoon <pmuldoon@redhat.com>
> Date: Mon, 06 Apr 2015 19:27:16 +0200
> 
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -53,6 +53,9 @@ record btrace bts
>  record bts
>    Start branch trace recording using Branch Trace Store (BTS) format.
>  
> +compile print
> +  Evaluate expression with the compiler and print result.

Perhaps "by using the compiler" or "by compiling and running it"?
Saying "with the compiler" is slightly incorrect here, and might even
be confusing, if some non-native speaker interprets the "with" as
referring to "expression" and not to "evaluate".

> +  add_cmd ("print", class_obscure, compile_print_command,
> +	   _("\
> +Evaluate EXPR with the compiler and print result.\n\

Same here.

> +Alternatively, you can type the expression interactively.\n\
> +You can invoke this mode when no argument is given to the command\n\
> +(i.e., \"compile print\" is typed with nothing after it).  An\n\
> +interactive prompt will be shown allowing you to enter multiple\n\
> +lines of source code.  Type a line containing \"end\" to indicate\n\
> +the end of the source code.\n\

I suggest to rephrase:

  Alternatively, you can type a multiline expression by invoking
  this command with no argument.  GDB will then prompt for the
  expression interactively; type a line containing "end" to
  indicate the end of the expression.

> +@table @code
> +@item compile print @var{expr}
> +@itemx compile print /@var{f} @var{expr}
> +Compile @var{expr} with the compiler language found as the current

"Compile and execute", I would think.

The documentation parts are OK with those changes.


  reply	other threads:[~2015-04-06 17:41 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-06 17:26 [PATCH v2 0/9] compile: compile print&printf Jan Kratochvil
2015-04-06 17:26 ` [PATCH v2 3/9] Code cleanup: compile: Constify some parameters Jan Kratochvil
2015-04-06 17:26 ` [PATCH v2 1/9] Code cleanup: Make parts of print_command_1 public Jan Kratochvil
2015-04-06 17:26 ` [PATCH v2 2/9] compile: Distribute scope, add scope_data Jan Kratochvil
2015-04-06 17:26 ` [PATCH v2 4/9] compile: Support relocation to GNU-IFUNCs Jan Kratochvil
2015-04-06 17:27 ` [PATCH v2 8/9] compile: New compile printf Jan Kratochvil
2015-04-06 17:27 ` [PATCH v2 5/9] compile: Use -Wall, not -w Jan Kratochvil
2015-04-06 17:27 ` [PATCH v2 9/9] compile: compile printf: gdbserver support Jan Kratochvil
2015-04-06 17:43   ` Eli Zaretskii
2015-04-11 19:23     ` Jan Kratochvil
2015-04-11 19:31       ` Eli Zaretskii
2015-04-06 17:27 ` [PATCH v2 6/9] Code cleanup: compile: func_addr -> func_sym Jan Kratochvil
2015-04-06 17:27 ` [PATCH v2 7/9] compile: New 'compile print' Jan Kratochvil
2015-04-06 17:41   ` Eli Zaretskii [this message]
2015-04-06 17:49     ` Paul_Koning
     [not found]       ` <20150406175250.GA314@host1.jankratochvil.net>
2015-04-06 18:00         ` Paul_Koning
2015-04-08 20:03           ` Jan Kratochvil
2015-04-09  7:39             ` Eli Zaretskii
2015-04-09 17:40               ` [doc patch] compile: missing bits [Re: [PATCH v2 7/9] compile: New 'compile print'] Jan Kratochvil
2015-04-09 18:12                 ` Eli Zaretskii
2015-04-10  8:09                   ` Jan Kratochvil
2015-04-10  8:31                     ` Eli Zaretskii
2015-04-10  8:35                       ` [commit] " Jan Kratochvil
2015-04-10 14:09                     ` Paul_Koning
2015-04-08 20:12           ` [PATCH v2 7/9] compile: New 'compile print' Paul_Koning
2015-04-08 20:33             ` Jan Kratochvil
2015-04-06 18:47         ` Jan Kratochvil
2015-04-11 19:20     ` Jan Kratochvil
2015-04-11 19:46 ` obsolete: [PATCH v2 0/9] compile: compile print&printf Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83bnj1jgsw.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=pmuldoon@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox