From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32829 invoked by alias); 6 Apr 2015 17:41:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32768 invoked by uid 89); 6 Apr 2015 17:41:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout24.012.net.il Received: from mtaout24.012.net.il (HELO mtaout24.012.net.il) (80.179.55.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 Apr 2015 17:41:00 +0000 Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0NME00200BAHPF00@mtaout24.012.net.il> for gdb-patches@sourceware.org; Mon, 06 Apr 2015 20:32:30 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NME00FFFBE5Z5A0@mtaout24.012.net.il>; Mon, 06 Apr 2015 20:32:30 +0300 (IDT) Date: Mon, 06 Apr 2015 17:41:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH v2 7/9] compile: New 'compile print' In-reply-to: <20150406172716.31404.8551.stgit@host1.jankratochvil.net> To: Jan Kratochvil Cc: gdb-patches@sourceware.org, pmuldoon@redhat.com Reply-to: Eli Zaretskii Message-id: <83bnj1jgsw.fsf@gnu.org> References: <20150406172623.31404.58833.stgit@host1.jankratochvil.net> <20150406172716.31404.8551.stgit@host1.jankratochvil.net> X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00169.txt.bz2 > From: Jan Kratochvil > Cc: Phil Muldoon > Date: Mon, 06 Apr 2015 19:27:16 +0200 > > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -53,6 +53,9 @@ record btrace bts > record bts > Start branch trace recording using Branch Trace Store (BTS) format. > > +compile print > + Evaluate expression with the compiler and print result. Perhaps "by using the compiler" or "by compiling and running it"? Saying "with the compiler" is slightly incorrect here, and might even be confusing, if some non-native speaker interprets the "with" as referring to "expression" and not to "evaluate". > + add_cmd ("print", class_obscure, compile_print_command, > + _("\ > +Evaluate EXPR with the compiler and print result.\n\ Same here. > +Alternatively, you can type the expression interactively.\n\ > +You can invoke this mode when no argument is given to the command\n\ > +(i.e., \"compile print\" is typed with nothing after it). An\n\ > +interactive prompt will be shown allowing you to enter multiple\n\ > +lines of source code. Type a line containing \"end\" to indicate\n\ > +the end of the source code.\n\ I suggest to rephrase: Alternatively, you can type a multiline expression by invoking this command with no argument. GDB will then prompt for the expression interactively; type a line containing "end" to indicate the end of the expression. > +@table @code > +@item compile print @var{expr} > +@itemx compile print /@var{f} @var{expr} > +Compile @var{expr} with the compiler language found as the current "Compile and execute", I would think. The documentation parts are OK with those changes.