Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Per-inferior thread IDs
Date: Fri, 18 Dec 2015 19:36:00 -0000	[thread overview]
Message-ID: <83bn9nwnui.fsf@gnu.org> (raw)
In-Reply-To: <56744C3A.3040407@redhat.com> (message from Pedro Alves on Fri,	18 Dec 2015 18:11:06 +0000)

> Date: Fri, 18 Dec 2015 18:11:06 +0000
> From: Pedro Alves <palves@redhat.com>
> CC: gdb-patches@sourceware.org
> 
> >> +@kindex thread @var{thread-id}
> >> +@item thread @var{thread-id}
> >> +Make thread ID @var{thread-id} the current thread.  The command
> >> +argument @var{thread-id} is the internal @value{GDBN} thread ID, as
> >                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> >>  shown in the first field of the @samp{info threads} display.
> > 
> > Why not use "qualified thread ID" here?
> 
> This is not always inferior-qualified.  It depends on whether you
> created a second inferior, as described earlier in the thread IDs
> description:
> 
>  Until you create a second inferior, @value{GDBN} does not show the
>  @var{inferior-num} part of thread IDs, even though you can always use
>  the full @var{inferior-num}.@var{thread-num} form to refer to threads
>  of inferior 1, the initial inferior.
> 
> Should I drop "internal", perhaps?

Yes, I think so.

> In any case, I've added an example now:
> 
> +Make thread ID @var{thread-id} the current thread.  The command
> +argument @var{thread-id} is the internal @value{GDBN} thread ID, as
> +shown in the first field of the @samp{info threads} display, with or
> +without an inferior qualifier (e.g., @samp{2.1} or @samp{1}).

An example always helps, so this is even better.

> Thank you very much for the review and suggestions thus far.
> Here's an updated docs patch.  Let me know how it looks.

LGTM, thanks.


  reply	other threads:[~2015-12-18 19:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-15 19:05 Pedro Alves
2015-12-15 19:39 ` Eli Zaretskii
2015-12-17 13:17   ` Pedro Alves
2015-12-17 16:54     ` Eli Zaretskii
2015-12-18 18:11       ` Pedro Alves
2015-12-18 19:36         ` Eli Zaretskii [this message]
2015-12-24 14:56         ` [PATCH] thread ID ranges (Per-inferior thread IDs) Pedro Alves
2015-12-24 16:24           ` Eli Zaretskii
2015-12-18 17:53 ` [PATCH] Per-inferior thread IDs Joel Brobecker
2015-12-18 18:47   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83bn9nwnui.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox