From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111550 invoked by alias); 18 Dec 2015 19:36:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 111540 invoked by uid 89); 18 Dec 2015 19:36:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=HX-Received-From:134, HX-Received-From:4830, HX-Received-From:2001, HX-HELO:eggs.gnu.org X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 18 Dec 2015 19:36:20 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aA0p3-0000AD-QT for gdb-patches@sourceware.org; Fri, 18 Dec 2015 14:36:18 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47597) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aA0p3-0000A3-N1; Fri, 18 Dec 2015 14:36:13 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2077 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aA0p3-0001am-3c; Fri, 18 Dec 2015 14:36:13 -0500 Date: Fri, 18 Dec 2015 19:36:00 -0000 Message-Id: <83bn9nwnui.fsf@gnu.org> From: Eli Zaretskii To: Pedro Alves CC: gdb-patches@sourceware.org In-reply-to: <56744C3A.3040407@redhat.com> (message from Pedro Alves on Fri, 18 Dec 2015 18:11:06 +0000) Subject: Re: [PATCH] Per-inferior thread IDs Reply-to: Eli Zaretskii References: <1450206316-25680-1-git-send-email-palves@redhat.com> <8337v333id.fsf@gnu.org> <5672B5D0.6020806@redhat.com> <83a8p9yq0p.fsf@gnu.org> <56744C3A.3040407@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00386.txt.bz2 > Date: Fri, 18 Dec 2015 18:11:06 +0000 > From: Pedro Alves > CC: gdb-patches@sourceware.org > > >> +@kindex thread @var{thread-id} > >> +@item thread @var{thread-id} > >> +Make thread ID @var{thread-id} the current thread. The command > >> +argument @var{thread-id} is the internal @value{GDBN} thread ID, as > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > >> shown in the first field of the @samp{info threads} display. > > > > Why not use "qualified thread ID" here? > > This is not always inferior-qualified. It depends on whether you > created a second inferior, as described earlier in the thread IDs > description: > > Until you create a second inferior, @value{GDBN} does not show the > @var{inferior-num} part of thread IDs, even though you can always use > the full @var{inferior-num}.@var{thread-num} form to refer to threads > of inferior 1, the initial inferior. > > Should I drop "internal", perhaps? Yes, I think so. > In any case, I've added an example now: > > +Make thread ID @var{thread-id} the current thread. The command > +argument @var{thread-id} is the internal @value{GDBN} thread ID, as > +shown in the first field of the @samp{info threads} display, with or > +without an inferior qualifier (e.g., @samp{2.1} or @samp{1}). An example always helps, so this is even better. > Thank you very much for the review and suggestions thus far. > Here's an updated docs patch. Let me know how it looks. LGTM, thanks.