From: Eli Zaretskii <eliz@gnu.org>
To: Hannes Domani <ssbssa@yahoo.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Implement debugging of WOW64 processes
Date: Wed, 04 Mar 2020 17:33:00 -0000 [thread overview]
Message-ID: <83blpcvxdl.fsf@gnu.org> (raw)
In-Reply-To: <20200304171216.28885-1-ssbssa@yahoo.de> (gdb-patches@sourceware.org)
> From: "Hannes Domani via gdb-patches" <gdb-patches@sourceware.org>
> Date: Wed, 4 Mar 2020 18:12:16 +0100
>
> For WOW64 processes, the Wow64* variants of SuspendThread,
> GetThreadContext, SetThreadContext, and GetThreadSelectorEntry have to
> be used instead.
> And instead of EnumProcessModules, EnumProcessModulesEx with
> LIST_MODULES_32BIT is necessary.
>
> gdb/ChangeLog:
>
> 2020-03-04 Hannes Domani <ssbssa@yahoo.de>
>
> * NEWS: Mention support for WOW64 processes.
> * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
> (amd64_windows_segment_register_p): Remove static.
> (_initialize_amd64_windows_nat): Update.
> * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
> * i386-windows-nat.c (context_offset): Update.
> (i386_mappings): Rename and remove static.
> (i386_windows_segment_register_p): Remove static.
> (_initialize_i386_windows_nat): Update.
> * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
> (STATUS_WX86_SINGLE_STEP): New macro.
> (EnumProcessModulesEx): New macro.
> (Wow64SuspendThread): New macro.
> (Wow64GetThreadContext): New macro.
> (Wow64SetThreadContext): New macro.
> (Wow64GetThreadSelectorEntry): New macro.
> (windows_add_thread): Adapt for WOW64 processes.
> (windows_fetch_one_register): Likewise.
> (windows_nat_target::fetch_registers): Likewise.
> (windows_store_one_register): Likewise.
> (display_selector): Likewise.
> (display_selectors): Likewise.
> (handle_exception): Likewise.
> (windows_continue): Likewise.
> (windows_nat_target::resume): Likewise.
> (windows_add_all_dlls): Likewise.
> (do_initial_windows_stuff): Likewise.
> (windows_nat_target::attach): Likewise.
> (windows_get_exec_module_filename): Likewise.
> (windows_nat_target::create_inferior): Likewise.
> (windows_xfer_siginfo): Likewise.
> (_initialize_loadable): Initialize Wow64SuspendThread,
> Wow64GetThreadContext, Wow64SetThreadContext,
> Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
> * windows-nat.h (i386_windows_segment_register_p): Add declaration.
> (amd64_windows_segment_register_p): Likewise.
The NEWS part is OK, thanks.
I also read the rest of the patch and didn't spot anything wrong.
next prev parent reply other threads:[~2020-03-04 17:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200304171216.28885-1-ssbssa.ref@yahoo.de>
2020-03-04 17:12 ` Hannes Domani via gdb-patches
2020-03-04 17:33 ` Eli Zaretskii [this message]
2020-03-04 18:15 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83blpcvxdl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=ssbssa@yahoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox