From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8215 invoked by alias); 4 Mar 2020 17:33:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8207 invoked by uid 89); 4 Mar 2020 17:33:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Mar 2020 17:33:18 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55295) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j9XtT-00030z-HP; Wed, 04 Mar 2020 12:33:15 -0500 Received: from [176.228.60.248] (port=4813 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j9XtS-0005TJ-Mo; Wed, 04 Mar 2020 12:33:15 -0500 Date: Wed, 04 Mar 2020 17:33:00 -0000 Message-Id: <83blpcvxdl.fsf@gnu.org> From: Eli Zaretskii To: Hannes Domani Cc: gdb-patches@sourceware.org In-Reply-To: <20200304171216.28885-1-ssbssa@yahoo.de> (gdb-patches@sourceware.org) Subject: Re: [PATCH v2] Implement debugging of WOW64 processes References: <20200304171216.28885-1-ssbssa.ref@yahoo.de> <20200304171216.28885-1-ssbssa@yahoo.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2020-03/txt/msg00093.txt > From: "Hannes Domani via gdb-patches" > Date: Wed, 4 Mar 2020 18:12:16 +0100 > > For WOW64 processes, the Wow64* variants of SuspendThread, > GetThreadContext, SetThreadContext, and GetThreadSelectorEntry have to > be used instead. > And instead of EnumProcessModules, EnumProcessModulesEx with > LIST_MODULES_32BIT is necessary. > > gdb/ChangeLog: > > 2020-03-04 Hannes Domani > > * NEWS: Mention support for WOW64 processes. > * amd64-windows-nat.c (amd64_mappings): Rename and remove static. > (amd64_windows_segment_register_p): Remove static. > (_initialize_amd64_windows_nat): Update. > * configure.nat (NATDEPFILES): Add i386-windows-nat.o. > * i386-windows-nat.c (context_offset): Update. > (i386_mappings): Rename and remove static. > (i386_windows_segment_register_p): Remove static. > (_initialize_i386_windows_nat): Update. > * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro. > (STATUS_WX86_SINGLE_STEP): New macro. > (EnumProcessModulesEx): New macro. > (Wow64SuspendThread): New macro. > (Wow64GetThreadContext): New macro. > (Wow64SetThreadContext): New macro. > (Wow64GetThreadSelectorEntry): New macro. > (windows_add_thread): Adapt for WOW64 processes. > (windows_fetch_one_register): Likewise. > (windows_nat_target::fetch_registers): Likewise. > (windows_store_one_register): Likewise. > (display_selector): Likewise. > (display_selectors): Likewise. > (handle_exception): Likewise. > (windows_continue): Likewise. > (windows_nat_target::resume): Likewise. > (windows_add_all_dlls): Likewise. > (do_initial_windows_stuff): Likewise. > (windows_nat_target::attach): Likewise. > (windows_get_exec_module_filename): Likewise. > (windows_nat_target::create_inferior): Likewise. > (windows_xfer_siginfo): Likewise. > (_initialize_loadable): Initialize Wow64SuspendThread, > Wow64GetThreadContext, Wow64SetThreadContext, > Wow64GetThreadSelectorEntry and EnumProcessModulesEx. > * windows-nat.h (i386_windows_segment_register_p): Add declaration. > (amd64_windows_segment_register_p): Likewise. The NEWS part is OK, thanks. I also read the rest of the patch and didn't spot anything wrong.