From: Eli Zaretskii <eliz@gnu.org>
To: Keith Seitz <keiths@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 0/5] Explicit linespecs
Date: Sun, 29 Jul 2012 19:36:00 -0000 [thread overview]
Message-ID: <83a9yigy2f.fsf@gnu.org> (raw)
In-Reply-To: <50158603.60503@redhat.com>
> Date: Sun, 29 Jul 2012 11:50:43 -0700
> From: Keith Seitz <keiths@redhat.com>
> CC: gdb-patches@sourceware.org
>
> On 07/27/2012 04:03 AM, Eli Zaretskii wrote:
>
> > What exactly does the "offset" option do? Is it a line offset, or is
> > it measured in other units? If it's a line offset, then why not call
> > it "-line"? If "offset" means it's a relative line offset, then what
> > is it relative to?
>
> It is completely analogous to the linespec parser. It could be an
> absolute line number (if -source given) or relative (if
> -function/-label).
We need to explain all that in the manual. It is completely
non-obvious.
> I can certainly rename the option to be more user-friendly.
IMO, we should indeed rename it.
> > Also, the above doesn't seem to cover the magical '*function' location
> > spec.
>
> That's the -address option.
This should also be explained. "Valid code address" certainly does
not hint of it.
Thanks.
next prev parent reply other threads:[~2012-07-29 19:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-27 3:45 Keith Seitz
2012-07-27 11:03 ` Eli Zaretskii
2012-07-29 18:51 ` Keith Seitz
2012-07-29 19:36 ` Eli Zaretskii [this message]
2012-08-01 10:14 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a9yigy2f.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox