From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-93273-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31702 invoked by alias); 29 Jul 2012 19:36:04 -0000
Received: (qmail 31694 invoked by uid 22791); 29 Jul 2012 19:36:04 -0000
X-SWARE-Spam-Status: No, hits=-4.1 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_NIX_SPAM,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 29 Jul 2012 19:35:48 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0M7X00D00T23AT00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Sun, 29 Jul 2012 22:35:31 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M7X00CTZT36PKA0@a-mtaout20.012.net.il>; Sun, 29 Jul 2012 22:35:31 +0300 (IDT)
Date: Sun, 29 Jul 2012 19:36:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA 0/5] Explicit linespecs
In-reply-to: <50158603.60503@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83a9yigy2f.fsf@gnu.org>
References: <50120ECF.4020709@redhat.com> <834notjwk1.fsf@gnu.org> <50158603.60503@redhat.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-07/txt/msg00729.txt.bz2

> Date: Sun, 29 Jul 2012 11:50:43 -0700
> From: Keith Seitz <keiths@redhat.com>
> CC: gdb-patches@sourceware.org
> 
> On 07/27/2012 04:03 AM, Eli Zaretskii wrote:
> 
> > What exactly does the "offset" option do?  Is it a line offset, or is
> > it measured in other units?  If it's a line offset, then why not call
> > it "-line"?  If "offset" means it's a relative line offset, then what
> > is it relative to?
> 
> It is completely analogous to the linespec parser. It could be an 
> absolute line number (if -source given) or relative (if 
> -function/-label).

We need to explain all that in the manual.  It is completely
non-obvious.

> I can certainly rename the option to be more user-friendly.

IMO, we should indeed rename it.

> > Also, the above doesn't seem to cover the magical '*function' location
> > spec.
> 
> That's the -address option.

This should also be explained.  "Valid code address" certainly does
not hint of it.

Thanks.