Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch][doc] PR python/10781
Date: Fri, 16 Oct 2009 07:46:00 -0000	[thread overview]
Message-ID: <838wfbixtf.fsf@gnu.org> (raw)
In-Reply-To: <4AD82247.3070503@redhat.com>

> Date: Fri, 16 Oct 2009 08:35:35 +0100
> From: Phil Muldoon <pmuldoon@redhat.com>
> 
> On irc,  Michael Lyle noticed that Value.cast was not documented in GDB 
> 7.0, but the method was available for use. Tom wrote this documentation 
> sometime ago, and it got missed on the merge. This patch fixes this.
> 
> OK?

I have a few comments:

> +Cast the @code{gdb.Value} to the type represented by @var{type}, and
        ^^^
Please remove this "the".

> +return a new @code{gdb.Value}.  @var{type} must be a @code{gdb.Type}
> +object.

If TYPE is an object, then it probably isn't a good idea to call it
TYPE.  Why not OBJECT?

Anyway, what does it mean "the type represented by TYPE"?  How can a
type be "represented"?  Did you perhaps mean "the type of TYPE"?

>       If the cast cannot be performed for some reason, an exception
> +is thrown.

Suggest to rephrase to avoid passive tense.

Thanks.


  reply	other threads:[~2009-10-16  7:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-16  7:35 Phil Muldoon
2009-10-16  7:46 ` Eli Zaretskii [this message]
2009-10-16 18:07   ` Tom Tromey
2009-10-16 18:44     ` Eli Zaretskii
2009-10-16 18:49       ` Tom Tromey
2009-10-16 19:09         ` Eli Zaretskii
2009-10-19 17:50           ` Tom Tromey
2009-10-27 15:52           ` Phil Muldoon
2009-10-27 16:01             ` Phil Muldoon
2009-10-27 18:43             ` Eli Zaretskii
2009-10-27 20:58               ` Phil Muldoon
2009-10-27 21:14                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838wfbixtf.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=pmuldoon@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox