From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-67738-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 26269 invoked by alias); 16 Oct 2009 07:46:43 -0000
Received: (qmail 26261 invoked by uid 22791); 16 Oct 2009 07:46:42 -0000
X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 	tests=AWL,BAYES_00,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 16 Oct 2009 07:46:34 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0KRL00600JCGGL00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Fri, 16 Oct 2009 09:46:31 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.70.117.47]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KRL0061ZK9FY820@a-mtaout22.012.net.il>; Fri, 16 Oct 2009 09:46:28 +0200 (IST)
Date: Fri, 16 Oct 2009 07:46:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch][doc] PR python/10781
In-reply-to: <4AD82247.3070503@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <838wfbixtf.fsf@gnu.org>
References: <4AD82247.3070503@redhat.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-10/txt/msg00361.txt.bz2

> Date: Fri, 16 Oct 2009 08:35:35 +0100
> From: Phil Muldoon <pmuldoon@redhat.com>
> 
> On irc,  Michael Lyle noticed that Value.cast was not documented in GDB 
> 7.0, but the method was available for use. Tom wrote this documentation 
> sometime ago, and it got missed on the merge. This patch fixes this.
> 
> OK?

I have a few comments:

> +Cast the @code{gdb.Value} to the type represented by @var{type}, and
        ^^^
Please remove this "the".

> +return a new @code{gdb.Value}.  @var{type} must be a @code{gdb.Type}
> +object.

If TYPE is an object, then it probably isn't a good idea to call it
TYPE.  Why not OBJECT?

Anyway, what does it mean "the type represented by TYPE"?  How can a
type be "represented"?  Did you perhaps mean "the type of TYPE"?

>       If the cast cannot be performed for some reason, an exception
> +is thrown.

Suggest to rephrase to avoid passive tense.

Thanks.