Re: [RFA PATCH] Accept "set foo unlimited" in integer/uinteger/zuinteger_unlimited commands.

[Eli Zaretskii <eliz@gnu.org>]

> From: Pedro Alves <palves@redhat.com>
> Date: Wed, 27 Mar 2013 16:45:10 +0000
> 
> Currently, several commands take "0" or "-1" to mean "unlimited".
> 
> "show" knows when to print "unlimited":
> 
>  (gdb) show height
>  Number of lines gdb thinks are in a page is 45.
>  (gdb) set height 0
>  (gdb) show height
>  Number of lines gdb thinks are in a page is unlimited.
> 
> However, the user can't herself specify "unlimited" directly:
> 
>  (gdb) set height unlimited
>  No symbol table is loaded.  Use the "file" command.
>  (gdb)
> 
> This patch addresses that, by adjusting the set handler for all
> integer/uinteger/zuinteger_unlimited commands to accept literal
> "unlimited".  It also installs a completer.

Thanks!

> Okay?

A few comments from me:

> gdb/doc/
> 2013-03-27  Pedro Alves  <palves@redhat.com>
> 
> 	* gdb.texinfo (set record full insn-number-max): Document
> 	"unlimited".
> 	(set record instruction-history-size): Likewise.
> 	(set record function-call-history-size): Likewise.
> 	(set backtrace limit): Likewise.
> 	(set listsize): Likewise.
> 	(set print max-symbolic-offset): Likewise.
> 	(set print elements): Likewise.
> 	(set print repeats): Likewise.
> 	(set trace-buffer-size): Likewise.
> 	(set tcp connect-timeout): Likewise.
> 	(set history size): Likewise.
> 	(set height):
> 	(set width):
> 	(set pagination): Adjust to suggest "set height unlimited" instead
> 	of "set height 0".

Those aren't node names in the parens.  I thought we were always using
node names there.

> +If @var{limit} is @code{unlimited}, or zero, @value{GDBN} will never
                                     ^
This comma should be deleted.

> +                                                      The number of
> +recorded instructions is unlimited in this case.
                         ^^^^^^^^^^^^
I'd say "... is limited only by the available memory" instead.

The documentation parts are OK with those changes.