From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17413 invoked by alias); 27 Mar 2013 17:54:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17388 invoked by uid 89); 27 Mar 2013 17:53:57 -0000 X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_YE,SPF_SOFTFAIL autolearn=no version=3.3.1 Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 27 Mar 2013 17:53:53 +0000 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MKB00L00YUJT400@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Wed, 27 Mar 2013 19:53:51 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MKB00L93Z1NT210@a-mtaout23.012.net.il>; Wed, 27 Mar 2013 19:53:47 +0200 (IST) Date: Wed, 27 Mar 2013 18:51:00 -0000 From: Eli Zaretskii Subject: Re: [RFA PATCH] Accept "set foo unlimited" in integer/uinteger/zuinteger_unlimited commands. In-reply-to: <20130327164510.30832.43521.stgit@brno.lan> To: Pedro Alves Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <838v58ybic.fsf@gnu.org> References: <20130327164510.30832.43521.stgit@brno.lan> X-SW-Source: 2013-03/txt/msg01027.txt.bz2 > From: Pedro Alves > Date: Wed, 27 Mar 2013 16:45:10 +0000 > > Currently, several commands take "0" or "-1" to mean "unlimited". > > "show" knows when to print "unlimited": > > (gdb) show height > Number of lines gdb thinks are in a page is 45. > (gdb) set height 0 > (gdb) show height > Number of lines gdb thinks are in a page is unlimited. > > However, the user can't herself specify "unlimited" directly: > > (gdb) set height unlimited > No symbol table is loaded. Use the "file" command. > (gdb) > > This patch addresses that, by adjusting the set handler for all > integer/uinteger/zuinteger_unlimited commands to accept literal > "unlimited". It also installs a completer. Thanks! > Okay? A few comments from me: > gdb/doc/ > 2013-03-27 Pedro Alves > > * gdb.texinfo (set record full insn-number-max): Document > "unlimited". > (set record instruction-history-size): Likewise. > (set record function-call-history-size): Likewise. > (set backtrace limit): Likewise. > (set listsize): Likewise. > (set print max-symbolic-offset): Likewise. > (set print elements): Likewise. > (set print repeats): Likewise. > (set trace-buffer-size): Likewise. > (set tcp connect-timeout): Likewise. > (set history size): Likewise. > (set height): > (set width): > (set pagination): Adjust to suggest "set height unlimited" instead > of "set height 0". Those aren't node names in the parens. I thought we were always using node names there. > +If @var{limit} is @code{unlimited}, or zero, @value{GDBN} will never ^ This comma should be deleted. > + The number of > +recorded instructions is unlimited in this case. ^^^^^^^^^^^^ I'd say "... is limited only by the available memory" instead. The documentation parts are OK with those changes.