From: Eli Zaretskii <eliz@gnu.org>
To: Antoine Tremblay <antoine.tremblay@ericsson.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH V2 5/5] Support tracepoints for ARM linux in GDBServer
Date: Thu, 03 Nov 2016 17:51:00 -0000 [thread overview]
Message-ID: <838tt0moyd.fsf@gnu.org> (raw)
In-Reply-To: <20161103143300.24934-6-antoine.tremblay@ericsson.com> (message from Antoine Tremblay on Thu, 3 Nov 2016 10:33:00 -0400)
> From: Antoine Tremblay <antoine.tremblay@ericsson.com>
> CC: Antoine Tremblay <antoine.tremblay@ericsson.com>
> Date: Thu, 3 Nov 2016 10:33:00 -0400
>
> diff --git a/gdb/NEWS b/gdb/NEWS
> index a6b1282..233f11e 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -3,6 +3,8 @@
>
> *** Changes since GDB 7.12
>
> +* Support for tracepoints on arm-linux was added in GDBServer.
> +
> * Building GDB and GDBserver now requires a C++11 compiler.
>
> For example, GCC 4.8 or later.
This part is OK.
> +encodings as described below. If a @samp{K} is present, it
> +indicates a target specific breakpoint kind. The kind can be the
Please use @var{kind} here, in reference to the packet parameter.
> +length of the breakpoint. E.g., the arm and mips can insert either a
> +2 or 4 byte breakpoint or have additional meaning see
> +@ref{Architecture-Specific Protocol Details}. If the trailing @samp{-}
> +is present, further @samp{QTDP} packets will follow to specify this
> +tracepoint's actions.
This paragraph needs to use 2 spaces between sentences, not one.
The patch for the manual is OK with these gotchas fixed.
Thanks.
next prev parent reply other threads:[~2016-11-03 17:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-03 14:33 [PATCH V2 0/5] " Antoine Tremblay
2016-11-03 14:33 ` [PATCH V2 3/5] Improve tests to allow for targets that support trace but not ftrace Antoine Tremblay
2016-11-03 14:33 ` [PATCH V2 5/5] Support tracepoints for ARM linux in GDBServer Antoine Tremblay
2016-11-03 17:51 ` Eli Zaretskii [this message]
2016-11-03 18:12 ` Antoine Tremblay
2016-11-10 14:01 ` Yao Qi
2016-11-15 14:42 ` Antoine Tremblay
2016-11-16 20:49 ` Yao Qi
2016-11-03 14:33 ` [PATCH V2 1/5] Teach arm unwinders to terminate gracefully Antoine Tremblay
2016-11-03 14:33 ` [PATCH V2 2/5] Enable tracing of pseudo-registers on ARM Antoine Tremblay
2016-11-03 14:33 ` [PATCH V2 4/5] Use FAST_TRACEPOINT_LABEL in range-stepping.exp Antoine Tremblay
2016-11-07 9:25 ` [PATCH V2 0/5] Support tracepoints for ARM linux in GDBServer Yao Qi
[not found] ` <wwoka8dasqta.fsf@ericsson.com>
2016-11-08 15:34 ` Antoine Tremblay
2016-11-09 16:39 ` Yao Qi
2016-11-09 17:58 ` Antoine Tremblay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838tt0moyd.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=antoine.tremblay@ericsson.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox