From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33682 invoked by alias); 3 Nov 2016 17:51:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 33665 invoked by uid 89); 3 Nov 2016 17:51:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=antoine, 7.12, Antoine, H*m:fsf X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 03 Nov 2016 17:51:36 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c2MAl-0002Uv-M1 for gdb-patches@sourceware.org; Thu, 03 Nov 2016 13:51:34 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34064) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c2MAl-0002Up-IE; Thu, 03 Nov 2016 13:51:31 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1600 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1c2MAj-0002r0-5a; Thu, 03 Nov 2016 13:51:31 -0400 Date: Thu, 03 Nov 2016 17:51:00 -0000 Message-Id: <838tt0moyd.fsf@gnu.org> From: Eli Zaretskii To: Antoine Tremblay CC: gdb-patches@sourceware.org In-reply-to: <20161103143300.24934-6-antoine.tremblay@ericsson.com> (message from Antoine Tremblay on Thu, 3 Nov 2016 10:33:00 -0400) Subject: Re: [PATCH V2 5/5] Support tracepoints for ARM linux in GDBServer Reply-to: Eli Zaretskii References: <20161103143300.24934-1-antoine.tremblay@ericsson.com> <20161103143300.24934-6-antoine.tremblay@ericsson.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00064.txt.bz2 > From: Antoine Tremblay > CC: Antoine Tremblay > Date: Thu, 3 Nov 2016 10:33:00 -0400 > > diff --git a/gdb/NEWS b/gdb/NEWS > index a6b1282..233f11e 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -3,6 +3,8 @@ > > *** Changes since GDB 7.12 > > +* Support for tracepoints on arm-linux was added in GDBServer. > + > * Building GDB and GDBserver now requires a C++11 compiler. > > For example, GCC 4.8 or later. This part is OK. > +encodings as described below. If a @samp{K} is present, it > +indicates a target specific breakpoint kind. The kind can be the Please use @var{kind} here, in reference to the packet parameter. > +length of the breakpoint. E.g., the arm and mips can insert either a > +2 or 4 byte breakpoint or have additional meaning see > +@ref{Architecture-Specific Protocol Details}. If the trailing @samp{-} > +is present, further @samp{QTDP} packets will follow to specify this > +tracepoint's actions. This paragraph needs to use 2 spaces between sentences, not one. The patch for the manual is OK with these gotchas fixed. Thanks.