From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tom@tromey.com>
Cc: philippe.waroquiers@skynet.be, gdb-patches@sourceware.org
Subject: Re: Still some style problems with 8.3 branch
Date: Fri, 12 Apr 2019 12:39:00 -0000 [thread overview]
Message-ID: <838swfmm9e.fsf@gnu.org> (raw)
In-Reply-To: <878swg8i33.fsf@tromey.com> (message from Tom Tromey on Thu, 11 Apr 2019 13:20:16 -0600)
> From: Tom Tromey <tom@tromey.com>
> Cc: Philippe Waroquiers <philippe.waroquiers@skynet.be>, Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
> Date: Thu, 11 Apr 2019 13:20:16 -0600
>
> >>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
>
> Eli> I don't think it's due to buffering. If I #ifdef away this part near
> Eli> the end of prompt_for_continue:
>
> Eli> /* Restore the current styling. */
> Eli> if (can_emit_style_escape (gdb_stdout))
> Eli> emit_style_escape (applied_style);
>
> Eli> then the problem seems to go away. So I think this style setting is
> Eli> what causes the problem, probably because applied_style has the wrong
> Eli> value here?
>
> I think this is correct. Certainly applied_style has the wrong value
> here, since it was reset by the call to emit_style_escape near the top
> of prompt_for_continue.
>
> So, I think a patch to remove these lines is ok. I can do it if you want.
Thanks, I pushed this now to both branches.
prev parent reply other threads:[~2019-04-12 12:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-30 10:36 Philippe Waroquiers
2019-03-31 14:28 ` Eli Zaretskii
2019-04-03 18:21 ` Eli Zaretskii
2019-04-03 20:07 ` Tom Tromey
2019-04-07 10:08 ` Philippe Waroquiers
2019-04-11 19:21 ` Tom Tromey
2019-04-11 21:02 ` Philippe Waroquiers
2019-04-11 19:20 ` Tom Tromey
2019-04-12 12:39 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838swfmm9e.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=philippe.waroquiers@skynet.be \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox