From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-155317-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 28949 invoked by alias); 12 Apr 2019 12:39:06 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 28936 invoked by uid 89); 12 Apr 2019 12:39:06 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1012
X-HELO: eggs.gnu.org
Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 12 Apr 2019 12:39:04 +0000
Received: from fencepost.gnu.org ([2001:470:142:3::e]:59361)	by eggs.gnu.org with esmtp (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1hEvSO-0003vd-2a; Fri, 12 Apr 2019 08:39:02 -0400
Received: from [176.228.60.248] (port=2548 helo=home-c4e4a596f7)	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)	(Exim 4.82)	(envelope-from <eliz@gnu.org>)	id 1hEvSI-00039O-Qb; Fri, 12 Apr 2019 08:38:57 -0400
Date: Fri, 12 Apr 2019 12:39:00 -0000
Message-Id: <838swfmm9e.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tom@tromey.com>
CC: philippe.waroquiers@skynet.be, gdb-patches@sourceware.org
In-reply-to: <878swg8i33.fsf@tromey.com> (message from Tom Tromey on Thu, 11	Apr 2019 13:20:16 -0600)
Subject: Re: Still some style problems with 8.3 branch
References: <1553942211.1854.2.camel@skynet.be> <835zrzi0d7.fsf@gnu.org> <878swg8i33.fsf@tromey.com>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-IsSubscribed: yes
X-SW-Source: 2019-04/txt/msg00222.txt.bz2

> From: Tom Tromey <tom@tromey.com>
> Cc: Philippe Waroquiers <philippe.waroquiers@skynet.be>,  Tom Tromey <tom@tromey.com>,  gdb-patches@sourceware.org
> Date: Thu, 11 Apr 2019 13:20:16 -0600
> 
> >>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
> 
> Eli> I don't think it's due to buffering.  If I #ifdef away this part near
> Eli> the end of prompt_for_continue:
> 
> Eli>   /* Restore the current styling.  */
> Eli>   if (can_emit_style_escape (gdb_stdout))
> Eli>     emit_style_escape (applied_style);
> 
> Eli> then the problem seems to go away.  So I think this style setting is
> Eli> what causes the problem, probably because applied_style has the wrong
> Eli> value here?
> 
> I think this is correct.  Certainly applied_style has the wrong value
> here, since it was reset by the call to emit_style_escape near the top
> of prompt_for_continue.  
> 
> So, I think a patch to remove these lines is ok.  I can do it if you want.

Thanks, I pushed this now to both branches.