From: Eli Zaretskii via Gdb-patches <gdb-patches@sourceware.org>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] sim: use gnulib to set nonblocking mode
Date: Thu, 09 Sep 2021 10:24:18 +0300 [thread overview]
Message-ID: <837dfqky8t.fsf@gnu.org> (raw)
In-Reply-To: <20210909063836.16875-2-vapier@gentoo.org> (message from Mike Frysinger via Gdb-patches on Thu, 9 Sep 2021 02:38:36 -0400)
> Date: Thu, 9 Sep 2021 02:38:36 -0400
> From: Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org>
>
> Replace various custom ad-hoc fcntl/O_NONBLOCK implementations with
> the gnulib nonblocking module. This makes our code much tidier and
> portable to other systems (e.g. Windows).
I'm not familiar with the sim's code, but Gnulib AFAIK supports
non-blocking flag on MinGW only for named pipes and sockets, not for
real files. Are all the file descriptors in the places where you make
the changes of one of those kinds? E.g., I see the fcntl calls on
file descriptor zero in some places.
next prev parent reply other threads:[~2021-09-09 7:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 6:38 [PATCH 1/2] gnulib: import nonblocking module Mike Frysinger via Gdb-patches
2021-09-09 6:38 ` [PATCH 2/2] sim: use gnulib to set nonblocking mode Mike Frysinger via Gdb-patches
2021-09-09 7:24 ` Eli Zaretskii via Gdb-patches [this message]
2021-09-09 7:33 ` Mike Frysinger via Gdb-patches
2021-09-09 7:44 ` Eli Zaretskii via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837dfqky8t.fsf@gnu.org \
--to=gdb-patches@sourceware.org \
--cc=eliz@gnu.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox