From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id JnkEFa22OWHTeQAAWB0awg (envelope-from ) for ; Thu, 09 Sep 2021 03:24:29 -0400 Received: by simark.ca (Postfix, from userid 112) id 388BF1EE23; Thu, 9 Sep 2021 03:24:29 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D17741EDDB for ; Thu, 9 Sep 2021 03:24:27 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2EF1E384B0D2 for ; Thu, 9 Sep 2021 07:24:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2EF1E384B0D2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1631172267; bh=BoBRBwLCourBSULhgCy7MByg5gCHMurkgqj0V7rHR5c=; h=Date:To:In-Reply-To:Subject:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=KzT0/j2wkg4IiCJIfXdDApt5SflWfaeAsix2KRO2/qUyBsJzmjHGBiAhJ4BPf1emJ Cuk8v3AmbmlMIJo46xmlo1TujE+4Y3ZA/hKkTOXbpnxv+oBeei3ynPQrUvRh4iHoZs 94aGLXL9oUeFm7IlQJveADHLVk9yFo7fpEwy496s= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 6289A384C002 for ; Thu, 9 Sep 2021 07:24:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6289A384C002 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49762) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mOEPn-0004J8-Va; Thu, 09 Sep 2021 03:24:07 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4230 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mOEPn-0005b1-4W; Thu, 09 Sep 2021 03:24:07 -0400 Date: Thu, 09 Sep 2021 10:24:18 +0300 Message-Id: <837dfqky8t.fsf@gnu.org> To: Mike Frysinger In-Reply-To: <20210909063836.16875-2-vapier@gentoo.org> (message from Mike Frysinger via Gdb-patches on Thu, 9 Sep 2021 02:38:36 -0400) Subject: Re: [PATCH 2/2] sim: use gnulib to set nonblocking mode References: <20210909063836.16875-1-vapier@gentoo.org> <20210909063836.16875-2-vapier@gentoo.org> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > Date: Thu, 9 Sep 2021 02:38:36 -0400 > From: Mike Frysinger via Gdb-patches > > Replace various custom ad-hoc fcntl/O_NONBLOCK implementations with > the gnulib nonblocking module. This makes our code much tidier and > portable to other systems (e.g. Windows). I'm not familiar with the sim's code, but Gnulib AFAIK supports non-blocking flag on MinGW only for named pipes and sockets, not for real files. Are all the file descriptors in the places where you make the changes of one of those kinds? E.g., I see the fcntl calls on file descriptor zero in some places.