From: Eli Zaretskii via Gdb-patches <gdb-patches@sourceware.org>
To: Guinevere Larsen <blarsen@redhat.com>
Cc: gdb-patches@sourceware.org, kevinb@redhat.com
Subject: Re: [PATCH v5 1/1] [gdb]: add git trailer information on gdb/MAINTAINERS
Date: Thu, 05 Oct 2023 19:01:52 +0300 [thread overview]
Message-ID: <837co13vnz.fsf@gnu.org> (raw)
In-Reply-To: <20231005113533.86112-3-blarsen@redhat.com> (message from Guinevere Larsen on Thu, 5 Oct 2023 13:35:34 +0200)
> From: Guinevere Larsen <blarsen@redhat.com>
> Cc: eliz@gnu.org,
> Guinevere Larsen <blarsen@redhat.com>,
> Kevin Buettner <kevinb@redhat.com>
> Date: Thu, 5 Oct 2023 13:35:34 +0200
>
> + - Acked-By:
> +
> + Used by a responsible or global maintainer when the patch touches multiple
> + areas of GDB, and the maintainer in question is only approving some of
> + those areas. When using this tag, add the area(s) at the end of the text.
> + This tag is also often described as "partial approval"
> + Usage: "Acked-By: Your Name <your@email> (area)"
What are the possible "area"s? And how to indicate more than a single
area?
And a more general question: when the review comments are minor, we
are used to say something like "okay with those nits fixed", meaning
that there's no need for posting another version of the patch before
committing it "with those nits fixed". Is this an
Acked-By/Approved-By or Reviewed-By?
Thanks.
next prev parent reply other threads:[~2023-10-05 16:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 11:35 [PATCH v5 0/1] update MAINTAINERS file with git trailers Guinevere Larsen via Gdb-patches
2023-10-05 11:35 ` [PATCH v5 1/1] [gdb]: add git trailer information on gdb/MAINTAINERS Guinevere Larsen via Gdb-patches
2023-10-05 14:31 ` Simon Marchi via Gdb-patches
2023-10-05 16:01 ` Eli Zaretskii via Gdb-patches [this message]
2023-10-06 7:39 ` Guinevere Larsen via Gdb-patches
2023-10-06 11:11 ` Eli Zaretskii via Gdb-patches
2023-10-05 17:55 ` Kevin Buettner via Gdb-patches
2023-10-09 9:59 ` Guinevere Larsen
2023-10-10 15:14 ` Simon Marchi
2023-10-26 12:46 ` Lancelot SIX
2023-10-25 14:34 ` [PING][PATCH v5 0/1] update MAINTAINERS file with git trailers Guinevere Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837co13vnz.fsf@gnu.org \
--to=gdb-patches@sourceware.org \
--cc=blarsen@redhat.com \
--cc=eliz@gnu.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox