Re: Re : New language support : Vala

[Eli Zaretskii <eliz@gnu.org>]

> Cc: gdb-patches@sourceware.org
> From: Tom Tromey <tromey@redhat.com>
> Date: Mon, 13 Apr 2009 18:28:37 -0600
> 
> Tom> I don't know whether your FSF paperwork has gone through.  I don't
> Tom> have a way to look that up any more; maybe someone else could find
> Tom> out.
> 
> Abderrahim> Yes, I received the letter.
> 
> Ok.  The important bit for us is knowing when the FSF says that you
> are all set up.

I see that Abderrahim's name is already on file in the FSF copyright
assignments list.

> +      TYPE_CODE (type =
> +		 check_typedef (TYPE_TARGET_TYPE (type))) == TYPE_CODE_STRUCT)
> 
> GNU style prohibits embedded assignments like this.

Only inside an `if', which this one is not:

       Try to avoid assignments inside `if'-conditions (assignments inside
    `while'-conditions are ok).  For example, don't write this:

	 if ((foo = (char *) malloc (sizeof *foo)) == 0)
	   fatal ("virtual memory exhausted");

    instead, write this:

	 foo = (char *) malloc (sizeof *foo);
	 if (foo == 0)
	   fatal ("virtual memory exhausted");

That doesn't necessarily mean I'm opposed to Tom's comment, though:
unnecessary use of this style makes the source somewhat harder to
read.

> I know it is a pain, but this really needs test cases and
> documentation -- documentation for the users, and test cases so the
> gdb developers can test it occasionally.  ("Occasionally" since I
> assume most of us won't have the vala compiler installed.)

I think such an important new feature will also need an entry for
NEWS.

Thanks.