From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-62852-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 7046 invoked by alias); 14 Apr 2009 07:21:12 -0000
Received: (qmail 7034 invoked by uid 22791); 14 Apr 2009 07:21:11 -0000
X-SWARE-Spam-Status: No, hits=-0.7 required=5.0 	tests=AWL,BAYES_05,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout7.012.net.il (HELO mtaout7.012.net.il) (84.95.2.19)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 14 Apr 2009 07:21:04 +0000
Received: from conversion-daemon.i-mtaout7.012.net.il by i-mtaout7.012.net.il (HyperSendmail v2007.08) id <0KI200200XOYBG00@i-mtaout7.012.net.il> for gdb-patches@sourceware.org; Tue, 14 Apr 2009 10:21:01 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([84.229.240.185]) by i-mtaout7.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KI200DWOXQY7Y30@i-mtaout7.012.net.il>; Tue, 14 Apr 2009 10:20:59 +0300 (IDT)
Date: Tue, 14 Apr 2009 07:21:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: Re : New language support : Vala
In-reply-to: <m3prfgjcy2.fsf@fleche.redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: a.kitouni@gmail.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <8363h7og4d.fsf@gnu.org>
References: <3d6b0edb0902070607x29177016m48a40bd198b88f7e@mail.gmail.com> <m3wsc22fuv.fsf@fleche.redhat.com> <3d6b0edb0902090505m6bcb142crab53b0f860535ff4@mail.gmail.com> <3d6b0edb0902182352p7143c29clb382aa5602720463@mail.gmail.com> <m3fxi3ll1s.fsf@fleche.redhat.com> <3d6b0edb0903061044m2aa8671cn55940f43bc7db9a9@mail.gmail.com> <m3prfgjcy2.fsf@fleche.redhat.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-04/txt/msg00246.txt.bz2

> Cc: gdb-patches@sourceware.org
> From: Tom Tromey <tromey@redhat.com>
> Date: Mon, 13 Apr 2009 18:28:37 -0600
> 
> Tom> I don't know whether your FSF paperwork has gone through.  I don't
> Tom> have a way to look that up any more; maybe someone else could find
> Tom> out.
> 
> Abderrahim> Yes, I received the letter.
> 
> Ok.  The important bit for us is knowing when the FSF says that you
> are all set up.

I see that Abderrahim's name is already on file in the FSF copyright
assignments list.

> +      TYPE_CODE (type =
> +		 check_typedef (TYPE_TARGET_TYPE (type))) == TYPE_CODE_STRUCT)
> 
> GNU style prohibits embedded assignments like this.

Only inside an `if', which this one is not:

       Try to avoid assignments inside `if'-conditions (assignments inside
    `while'-conditions are ok).  For example, don't write this:

	 if ((foo = (char *) malloc (sizeof *foo)) == 0)
	   fatal ("virtual memory exhausted");

    instead, write this:

	 foo = (char *) malloc (sizeof *foo);
	 if (foo == 0)
	   fatal ("virtual memory exhausted");

That doesn't necessarily mean I'm opposed to Tom's comment, though:
unnecessary use of this style makes the source somewhat harder to
read.

> I know it is a pain, but this really needs test cases and
> documentation -- documentation for the users, and test cases so the
> gdb developers can test it occasionally.  ("Occasionally" since I
> assume most of us won't have the vala compiler installed.)

I think such an important new feature will also need an entry for
NEWS.

Thanks.