Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Jon Turney <jon.turney@dronecode.org.uk>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix a crash with a malformed PE header
Date: Thu, 02 Jan 2020 13:56:00 -0000	[thread overview]
Message-ID: <835zhuj71c.fsf@gnu.org> (raw)
In-Reply-To: <20200102125405.11499-1-jon.turney@dronecode.org.uk> (message	from Jon Turney on Thu, 2 Jan 2020 12:54:05 +0000)

> From: Jon Turney <jon.turney@dronecode.org.uk>
> Cc: Jon Turney <jon.turney@dronecode.org.uk>
> Date: Thu,  2 Jan 2020 12:54:05 +0000
> 
> --- a/gdb/coff-pe-read.c
> +++ b/gdb/coff-pe-read.c
> @@ -441,6 +441,12 @@ read_pe_exported_syms (minimal_symbol_reader &reader,
>  	}
>      }
>  
> +  if (expptr == 0)
> +    {
> +      /* no section contains export table rva */
> +      return;
> +    }
> +

Thanks.  Would it make sense to produce some diagnostic output here,
when an appropriate debug-FOO option is set?


  reply	other threads:[~2020-01-02 13:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-02 12:54 Jon Turney
2020-01-02 13:56 ` Eli Zaretskii [this message]
2020-01-03 13:11   ` Jon Turney
2020-01-03 13:20     ` Eli Zaretskii
2020-01-03 16:53     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=835zhuj71c.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jon.turney@dronecode.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox