From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-162709-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 25683 invoked by alias); 2 Jan 2020 13:56:35 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 25669 invoked by uid 89); 2 Jan 2020 13:56:34 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-8.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy=H*r:4.82
X-HELO: eggs.gnu.org
Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 02 Jan 2020 13:56:33 +0000
Received: from fencepost.gnu.org ([2001:470:142:3::e]:55747)	by eggs.gnu.org with esmtp (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1in0xj-0000Mw-2V; Thu, 02 Jan 2020 08:56:31 -0500
Received: from [176.228.60.248] (port=3543 helo=home-c4e4a596f7)	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)	(Exim 4.82)	(envelope-from <eliz@gnu.org>)	id 1in0xi-0007do-5i; Thu, 02 Jan 2020 08:56:30 -0500
Date: Thu, 02 Jan 2020 13:56:00 -0000
Message-Id: <835zhuj71c.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Jon Turney <jon.turney@dronecode.org.uk>
CC: gdb-patches@sourceware.org
In-reply-to: <20200102125405.11499-1-jon.turney@dronecode.org.uk> (message	from Jon Turney on Thu, 2 Jan 2020 12:54:05 +0000)
Subject: Re: [PATCH] Fix a crash with a malformed PE header
References: <20200102125405.11499-1-jon.turney@dronecode.org.uk>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-IsSubscribed: yes
X-SW-Source: 2020-01/txt/msg00023.txt.bz2

> From: Jon Turney <jon.turney@dronecode.org.uk>
> Cc: Jon Turney <jon.turney@dronecode.org.uk>
> Date: Thu,  2 Jan 2020 12:54:05 +0000
> 
> --- a/gdb/coff-pe-read.c
> +++ b/gdb/coff-pe-read.c
> @@ -441,6 +441,12 @@ read_pe_exported_syms (minimal_symbol_reader &reader,
>  	}
>      }
>  
> +  if (expptr == 0)
> +    {
> +      /* no section contains export table rva */
> +      return;
> +    }
> +

Thanks.  Would it make sense to produce some diagnostic output here,
when an appropriate debug-FOO option is set?