From: Eli Zaretskii via Gdb-patches <gdb-patches@sourceware.org>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCHv3 2/3] gdb: Restore previously selected thread when switching inferior
Date: Sat, 26 Sep 2020 09:09:59 +0300 [thread overview]
Message-ID: <835z81rruw.fsf@gnu.org> (raw)
In-Reply-To: <65f550256846e33e9c708f1d50878ee71d5d7ac4.1601070702.git.andrew.burgess@embecosm.com> (message from Andrew Burgess on Fri, 25 Sep 2020 23:24:08 +0100)
> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Fri, 25 Sep 2020 23:24:08 +0100
>
> This commit adds a new option that allows the user to control how GDB
> behaves when switching between multi-threaded inferiors.
Thanks. Some commas are missing, see below.
> +set restore-selected-thread on|off
> +show restore-selected-thread
> + This new option is off by default.
This sentence is redundant in NEWS, and IMO should be removed.
> + When turned on GDB will record
^
Please add a comma there.
> + the currently selected thread in each inferior. When switching
> + between inferiors GDB will attempt to restore the previously
^
And here.
> + selected thread in the inferior being switched too. If the
> + previously selected thread is no longer available then GDB falls
^
And there.
> +When switching between inferiors with multiple threads
> +(@pxref{Threads}) @value{GDBN} will select the first non-exited thread
^
Likewise.
> +in the inferior being switched to and make this the current thread.
^
Same.
> +When this option is on @value{GDBN} will record the currently selected
^
Here as well.
> +thread in each inferior. When switching between inferior @value{GDBN}
^
And here. Also, I think you meant "between inferiors", plural.
> -Otherwise, only @var{thread-num} is shown.
> +Otherwise, only @var{thread-num} is shown. When switching between
> +inferiors @value{GDBN} will select a suitable thread in the inferior
^
Please add a comma here.
> +being switched to, see @ref{inferior command,,the @code{inferior}
> +command} for further details on how to control this behaviour.
^
And here.
The documentation parts are okay with these fixed.
next prev parent reply other threads:[~2020-09-26 6:09 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 22:24 [PATCHv3 0/3] Restore thread and frame patches Andrew Burgess
2020-09-25 22:24 ` [PATCHv3 1/3] gdb: unify two copies of restore_selected_frame Andrew Burgess
2020-09-25 22:24 ` [PATCHv3 2/3] gdb: Restore previously selected thread when switching inferior Andrew Burgess
2020-09-26 6:09 ` Eli Zaretskii via Gdb-patches [this message]
2020-09-25 22:24 ` [PATCHv3 3/3] gdb: Track the current frame for each thread Andrew Burgess
2020-09-26 6:16 ` Eli Zaretskii via Gdb-patches
2020-09-26 8:31 ` Andreas Schwab
2020-09-26 8:54 ` Eli Zaretskii via Gdb-patches
2020-10-08 9:59 ` [PATCHv3 0/3] Restore thread and frame patches Andrew Burgess
2020-11-06 23:02 ` [PATCHv4 0/2] " Andrew Burgess
2020-11-06 23:02 ` [PATCHv4 1/2] gdb: Restore previously selected thread when switching inferior Andrew Burgess
2020-11-09 15:02 ` Aktemur, Tankut Baris via Gdb-patches
2020-11-06 23:02 ` [PATCHv4 2/2] gdb: Track the current frame for each thread Andrew Burgess
2020-11-12 11:59 ` [PATCHv5 0/2] Restore thread and frame patches Andrew Burgess
2020-12-10 11:39 ` [PATCHv6 " Andrew Burgess
2020-12-10 11:39 ` [PATCHv6 1/2] gdb: Restore previously selected thread when switching inferior Andrew Burgess
2020-12-10 11:39 ` [PATCHv6 2/2] gdb: Track the current frame for each thread Andrew Burgess
2020-12-18 8:43 ` Aktemur, Tankut Baris via Gdb-patches
2021-01-04 15:07 ` Andrew Burgess
2021-01-04 16:08 ` Eli Zaretskii via Gdb-patches
2021-01-07 10:25 ` [PATCHv6 0/2] Restore thread and frame patches Andrew Burgess
2021-02-12 18:20 ` [PATCHv7 " Andrew Burgess
2021-02-12 18:20 ` [PATCHv7 1/2] gdb: Restore previously selected thread when switching inferior Andrew Burgess
2021-02-12 18:20 ` [PATCHv7 2/2] gdb: Track the current frame for each thread Andrew Burgess
2021-03-23 11:13 ` [PATCHv8] gdb: Restore previously selected thread when switching inferior Andrew Burgess
2021-03-23 11:43 ` Eli Zaretskii via Gdb-patches
2020-11-12 11:59 ` [PATCHv5 1/2] " Andrew Burgess
2020-11-12 11:59 ` [PATCHv5 2/2] gdb: Track the current frame for each thread Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835z81rruw.fsf@gnu.org \
--to=gdb-patches@sourceware.org \
--cc=andrew.burgess@embecosm.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox