From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id B+ZkGC/bbl/XNwAAWB0awg (envelope-from ) for ; Sat, 26 Sep 2020 02:09:51 -0400 Received: by simark.ca (Postfix, from userid 112) id 52EA71EF4D; Sat, 26 Sep 2020 02:09:51 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A01611E509 for ; Sat, 26 Sep 2020 02:09:50 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 188953857005; Sat, 26 Sep 2020 06:09:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 188953857005 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1601100590; bh=D98iiuWrZ5BVFBJfmN7FNX3MaJZaR1UHAy/Dc69MXYI=; h=Date:To:In-Reply-To:Subject:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=OoT4oa8bf0Pp8pdEfLvzGUxN0Y6zevdh4QCfnWCVTA405S2AR7w0fTYYzsYM9SXKw Umd5JUq1MNak0Bi0/f9r5zo/z/LgvuXIQg28I866XMuXdrJIxOIwhtz2sa4/LGoIhv b2Pndl2H3mrXtabToKqblW7tlQP2/fwasg+QgToQ= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 675733857005 for ; Sat, 26 Sep 2020 06:09:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 675733857005 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56203) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kM3P1-0005Le-0Y; Sat, 26 Sep 2020 02:09:47 -0400 Received: from [176.228.60.248] (port=1447 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kM3Oz-0001jf-J9; Sat, 26 Sep 2020 02:09:46 -0400 Date: Sat, 26 Sep 2020 09:09:59 +0300 Message-Id: <835z81rruw.fsf@gnu.org> To: Andrew Burgess In-Reply-To: <65f550256846e33e9c708f1d50878ee71d5d7ac4.1601070702.git.andrew.burgess@embecosm.com> (message from Andrew Burgess on Fri, 25 Sep 2020 23:24:08 +0100) Subject: Re: [PATCHv3 2/3] gdb: Restore previously selected thread when switching inferior References: <65f550256846e33e9c708f1d50878ee71d5d7ac4.1601070702.git.andrew.burgess@embecosm.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > From: Andrew Burgess > Date: Fri, 25 Sep 2020 23:24:08 +0100 > > This commit adds a new option that allows the user to control how GDB > behaves when switching between multi-threaded inferiors. Thanks. Some commas are missing, see below. > +set restore-selected-thread on|off > +show restore-selected-thread > + This new option is off by default. This sentence is redundant in NEWS, and IMO should be removed. > + When turned on GDB will record ^ Please add a comma there. > + the currently selected thread in each inferior. When switching > + between inferiors GDB will attempt to restore the previously ^ And here. > + selected thread in the inferior being switched too. If the > + previously selected thread is no longer available then GDB falls ^ And there. > +When switching between inferiors with multiple threads > +(@pxref{Threads}) @value{GDBN} will select the first non-exited thread ^ Likewise. > +in the inferior being switched to and make this the current thread. ^ Same. > +When this option is on @value{GDBN} will record the currently selected ^ Here as well. > +thread in each inferior. When switching between inferior @value{GDBN} ^ And here. Also, I think you meant "between inferiors", plural. > -Otherwise, only @var{thread-num} is shown. > +Otherwise, only @var{thread-num} is shown. When switching between > +inferiors @value{GDBN} will select a suitable thread in the inferior ^ Please add a comma here. > +being switched to, see @ref{inferior command,,the @code{inferior} > +command} for further details on how to control this behaviour. ^ And here. The documentation parts are okay with these fixed.