From: Eli Zaretskii <eliz@gnu.org>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: Strip the ISA bit when printing symbol offsets
Date: Sat, 14 Nov 2009 09:28:00 -0000 [thread overview]
Message-ID: <834ooxo3sd.fsf@gnu.org> (raw)
In-Reply-To: <20091113212716.GA28795@caradoc.them.org>
> Date: Fri, 13 Nov 2009 16:27:16 -0500
> From: Daniel Jacobowitz <drow@false.org>
>
> When you compile a function in ARM's Thumb mode, the low bit of the
> function's address is set to indicate the use of an alternate
> instruction set.
>
> This currently causes failures in two tests (mi-var-child.exp and
> member-ptr.exp), because we print $hex <function+1> instead of the
> expected $hex <function>.
>
> What do you think of this patch, which causes us to strip off the low
> bit when computing the offset if FUNCTION is a function symbol (rather
> than a data variable)?
Isn't it true that an address of a function should always be aligned,
so that its LSB is always zero? If so, I don't think we need to pass
the architecture pointer to build_address_symbolic, we could just
always reset the LSB. WDYT?
next prev parent reply other threads:[~2009-11-14 9:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-13 21:27 Daniel Jacobowitz
2009-11-13 22:25 ` Joel Brobecker
2009-12-28 21:12 ` Daniel Jacobowitz
2009-11-14 9:28 ` Eli Zaretskii [this message]
2009-11-14 15:47 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834ooxo3sd.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox