From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29315 invoked by alias); 14 Nov 2009 09:28:32 -0000 Received: (qmail 29307 invoked by uid 22791); 14 Nov 2009 09:28:31 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 14 Nov 2009 09:27:27 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0KT300500E0JXN00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Sat, 14 Nov 2009 11:26:42 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.70.37.193]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KT3002WSE8HEA70@a-mtaout20.012.net.il>; Sat, 14 Nov 2009 11:26:42 +0200 (IST) Date: Sat, 14 Nov 2009 09:28:00 -0000 From: Eli Zaretskii Subject: Re: RFC: Strip the ISA bit when printing symbol offsets In-reply-to: <20091113212716.GA28795@caradoc.them.org> To: Daniel Jacobowitz Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <834ooxo3sd.fsf@gnu.org> References: <20091113212716.GA28795@caradoc.them.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00326.txt.bz2 > Date: Fri, 13 Nov 2009 16:27:16 -0500 > From: Daniel Jacobowitz > > When you compile a function in ARM's Thumb mode, the low bit of the > function's address is set to indicate the use of an alternate > instruction set. > > This currently causes failures in two tests (mi-var-child.exp and > member-ptr.exp), because we print $hex instead of the > expected $hex . > > What do you think of this patch, which causes us to strip off the low > bit when computing the offset if FUNCTION is a function symbol (rather > than a data variable)? Isn't it true that an address of a function should always be aligned, so that its LSB is always zero? If so, I don't think we need to pass the architecture pointer to build_address_symbolic, we could just always reset the LSB. WDYT?