Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 2/2] [+doc] New -iex and -ix: -ex and -x before inferior load
Date: Sat, 25 Feb 2012 16:54:00 -0000	[thread overview]
Message-ID: <834nuesy34.fsf@gnu.org> (raw)
In-Reply-To: <20120225134940.GC15155@host2.jankratochvil.net>

> Date: Sat, 25 Feb 2012 14:49:40 +0100
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> 
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -78,6 +78,13 @@ show breakpoint condition-evaluation
>    condition evaluation mode.  The use of this extension can be controlled
>    via the "set remote conditional-breakpoints-packet" command.
>  
> +* New command line options
> +
> +--init-command=FILE, -ix          Like --init-command, -x but execute it
                                          ^^^^^^^^^^^^^^
You meant "--command", I believe.

> +                                  before loading inferior.
> +--init-eval-command=COMMAND, -iex Like --eval-command=COMMAND, -ex but
> +                                  execute it before loading inferior.

Is it really a good idea to have 2- or 3-letter short options?  It
started with -nw and -nx, which might make sense, then we added -ex,
and now -ix and -iex?  If noting else, this will prevent us from ever
having -e and -i.

How about if we don't have short versions of these at all?

> +@cindex @code{-ix}
> +Execute commands from file @var{file} before gdbinit files or inferior loading.
                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
"before loading gdbinit files or the inferior" is better.

> +@cindex @code{-iex}
> +Execute a single @value{GDBN} command before gdbinit files or inferior loading.

Likewise.

> +Execute commands and command files specified by the @samp{-iex} and
> +@samp{-ix} options in their specified order.  Usually you should use the
> +@samp{-ex} and @samp{-x} options instead but this way you can apply
                                           ^
A comma is missing before "but".

OK with those changes.

Thanks.


  reply	other threads:[~2012-02-25 15:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-25 13:55 Jan Kratochvil
2012-02-25 16:54 ` Eli Zaretskii [this message]
2012-02-25 17:06   ` Jan Kratochvil
2012-02-28 16:34     ` Doug Evans
2012-03-16 20:39       ` ping: " Jan Kratochvil
2012-03-16 20:51         ` Tom Tromey
2012-02-28 16:28   ` Doug Evans
2012-03-19 18:20 ` [commit] " Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834nuesy34.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox