From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-88239-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12920 invoked by alias); 25 Feb 2012 15:57:58 -0000
Received: (qmail 12898 invoked by uid 22791); 25 Feb 2012 15:57:56 -0000
X-SWARE-Spam-Status: No, hits=-0.8 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 25 Feb 2012 15:57:42 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LZY00L00HKACG00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Sat, 25 Feb 2012 17:57:40 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.127.12.178]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LZY00J4JHO4UE11@a-mtaout22.012.net.il>; Sat, 25 Feb 2012 17:57:40 +0200 (IST)
Date: Sat, 25 Feb 2012 16:54:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch 2/2] [+doc] New -iex and -ix: -ex and -x before inferior load
In-reply-to: <20120225134940.GC15155@host2.jankratochvil.net>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <834nuesy34.fsf@gnu.org>
References: <20120225134940.GC15155@host2.jankratochvil.net>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-02/txt/msg00611.txt.bz2

> Date: Sat, 25 Feb 2012 14:49:40 +0100
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> 
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -78,6 +78,13 @@ show breakpoint condition-evaluation
>    condition evaluation mode.  The use of this extension can be controlled
>    via the "set remote conditional-breakpoints-packet" command.
>  
> +* New command line options
> +
> +--init-command=FILE, -ix          Like --init-command, -x but execute it
                                          ^^^^^^^^^^^^^^
You meant "--command", I believe.

> +                                  before loading inferior.
> +--init-eval-command=COMMAND, -iex Like --eval-command=COMMAND, -ex but
> +                                  execute it before loading inferior.

Is it really a good idea to have 2- or 3-letter short options?  It
started with -nw and -nx, which might make sense, then we added -ex,
and now -ix and -iex?  If noting else, this will prevent us from ever
having -e and -i.

How about if we don't have short versions of these at all?

> +@cindex @code{-ix}
> +Execute commands from file @var{file} before gdbinit files or inferior loading.
                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
"before loading gdbinit files or the inferior" is better.

> +@cindex @code{-iex}
> +Execute a single @value{GDBN} command before gdbinit files or inferior loading.

Likewise.

> +Execute commands and command files specified by the @samp{-iex} and
> +@samp{-ix} options in their specified order.  Usually you should use the
> +@samp{-ex} and @samp{-x} options instead but this way you can apply
                                           ^
A comma is missing before "but".

OK with those changes.

Thanks.