Re: Support for Xilinx MicroBlaze architecture (1 of 3)

[Eli Zaretskii <eliz@gnu.org>]

> Date: Fri, 11 Sep 2009 12:15:27 -0700
> From: Michael Eager <eager@eagercon.com>
> 
> The attached patch adds support for the Xilinx MicroBlaze architecture.

Thanks.

I have a few comments for the documentation part of the patch:

>                                                       By default
> +@code{xmd} uses port @code{1234}.

Is there a way to change this default, and if so, should we let the
user know how to do that?

> +@item target remote XMD-HOST:1234
> +@kindex target remote xmd-host>:1234
> +Use this command to connect to the target if you are running @value{GDBN}
> +on a different system @code{xmd}, which is running on @code{XMD-HOST}.

I understand that XMD-HOST stands for the real name of the host.  If
so, we use the @var markup in Texinfo for this:

  +@item target remote @var{xmd-host}:1234
  +Use this command to connect to the target if you are running @value{GDBN}
  +on a different system @code{xmd}, which is running on @var{xmd-host}.

Finally, the index entries you have are not useful: they all are for
commands that are not specific to the XMD target, and already have
index entries elsewhere in the manual, where the general form of these
commands is described.  What is needed in this section is @cindex
entries about the XMD itself, so that the reader could easily find
this section.  So I suggest these entries immediately after the
@subsection line:

  @cindex Xilinx MicroBlaze
  @cindex XMD, Xilinx Microprocessor Debugger

Okay with these changes.