From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10742 invoked by alias); 12 Sep 2009 08:47:35 -0000 Received: (qmail 10732 invoked by uid 22791); 12 Sep 2009 08:47:35 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout5.012.net.il (HELO mtaout5.012.net.il) (84.95.2.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 12 Sep 2009 08:47:31 +0000 Received: from conversion-daemon.i_mtaout5.012.net.il by i_mtaout5.012.net.il (HyperSendmail v2004.12) id <0KPU00600OAF3Y00@i_mtaout5.012.net.il> for gdb-patches@sourceware.org; Sat, 12 Sep 2009 11:47:28 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.228.50.163]) by i_mtaout5.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KPU00JZSOF2YAB0@i_mtaout5.012.net.il>; Sat, 12 Sep 2009 11:47:27 +0300 (IDT) Date: Sat, 12 Sep 2009 08:47:00 -0000 From: Eli Zaretskii Subject: Re: Support for Xilinx MicroBlaze architecture (1 of 3) In-reply-to: <4AAAA1CF.6080403@eagercon.com> To: Michael Eager Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <833a6s1rds.fsf@gnu.org> References: <4AAAA1CF.6080403@eagercon.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00364.txt.bz2 > Date: Fri, 11 Sep 2009 12:15:27 -0700 > From: Michael Eager > > The attached patch adds support for the Xilinx MicroBlaze architecture. Thanks. I have a few comments for the documentation part of the patch: > By default > +@code{xmd} uses port @code{1234}. Is there a way to change this default, and if so, should we let the user know how to do that? > +@item target remote XMD-HOST:1234 > +@kindex target remote xmd-host>:1234 > +Use this command to connect to the target if you are running @value{GDBN} > +on a different system @code{xmd}, which is running on @code{XMD-HOST}. I understand that XMD-HOST stands for the real name of the host. If so, we use the @var markup in Texinfo for this: +@item target remote @var{xmd-host}:1234 +Use this command to connect to the target if you are running @value{GDBN} +on a different system @code{xmd}, which is running on @var{xmd-host}. Finally, the index entries you have are not useful: they all are for commands that are not specific to the XMD target, and already have index entries elsewhere in the manual, where the general form of these commands is described. What is needed in this section is @cindex entries about the XMD itself, so that the reader could easily find this section. So I suggest these entries immediately after the @subsection line: @cindex Xilinx MicroBlaze @cindex XMD, Xilinx Microprocessor Debugger Okay with these changes.