Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Kevin Pouget <kevin.pouget@gmail.com>
Cc: tromey@redhat.com, pmuldoon@redhat.com, gdb-patches@sourceware.org
Subject: Re: [Patch][Python] PR python/13285 Document named constants for frame unwind stop reasons
Date: Thu, 13 Oct 2011 13:49:00 -0000	[thread overview]
Message-ID: <8339ex2eaf.fsf@gnu.org> (raw)
In-Reply-To: <CAPftXUK4L-ihoc7h61sn+6zd1nK9JcQzaCNGiktvArodas3DzQ@mail.gmail.com>

> From: Kevin Pouget <kevin.pouget@gmail.com>
> Date: Thu, 13 Oct 2011 14:39:16 +0200
> Cc: pmuldoon@redhat.com, gdb-patches@sourceware.org
> 
> I've prepared a bit of documentation for these named constants, based
> on their comments in the source code.

Thanks.

> +@table @code
> +@item gdb.FRAME_UNWIND_NO_REASON
> +No particular reason.

This begs for some explanation of when this "no-reason" reason will be
seen.  Is it true that this value is used when it's NOT impossible to
find more frames?  If so, we should say that explicitly.

> +@end table

There's no need to make each value a separate @table.  You can just
make them all be a single table, like this:

 @table @code
 @item foo
 Description of foo.
 @item bar
 Description of bar.
 ...
 @end @table.

OK with those changes.


  reply	other threads:[~2011-10-13 13:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-13 12:39 Kevin Pouget
2011-10-13 13:49 ` Eli Zaretskii [this message]
2011-10-13 14:06   ` Kevin Pouget
2011-10-14 11:57     ` Kevin Pouget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8339ex2eaf.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=kevin.pouget@gmail.com \
    --cc=pmuldoon@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox