Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] Make the go32-nat.c target inherit inf-child.c.
Date: Fri, 07 Mar 2014 15:32:00 -0000	[thread overview]
Message-ID: <831tyeqb2i.fsf@gnu.org> (raw)
In-Reply-To: <1394205292-19784-2-git-send-email-palves@redhat.com>

> From: Pedro Alves <palves@redhat.com>
> Date: Fri,  7 Mar 2014 15:14:50 +0000
> 
> So that all native targets inherit a single "superclass".
> 
> Target methods that are set to or do the same as inf-child.c's are
> removed.
> 
> Tested by cross building on Fedora 17.
> 
> gdb/
> 2014-03-07  Pedro Alves  <palves@redhat.com>
> 
> 	* go32-nat.c: Include inf-child.h.
> 	(go32_ops): Delete global.
> 	(go32_close, go32_detach, go32_prepare_to_store, go32_can_run):
> 	Delete methods.
> 	(go32_create_inferior): Push the passed in target pointer instead
> 	of referencing go32_ops.
> 	(init_go32_ops): Delete function.  Moved parts to _initialize_go32_nat.
> 	(go32_target): New function, based on init_go32_ops, but inherit
> 	inf_child_target.
> 	(_initialize_go32_nat): Use go32_target.  Move parts of
> 	init_go32_ops here.

This is OK, thanks.


  reply	other threads:[~2014-03-07 15:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-07 15:14 [PATCH 0/3] Make all native targets " Pedro Alves
2014-03-07 15:14 ` [PATCH 2/3] Make the windows-nat.c target " Pedro Alves
2014-03-11 16:42   ` Pedro Alves
2014-03-12  9:07     ` Joel Brobecker
2014-03-12 11:29       ` Pedro Alves
2014-03-07 15:15 ` [PATCH 3/3] Make the nto-procfs.c " Pedro Alves
2014-03-07 15:15 ` [PATCH 1/3] Make the go32-nat.c " Pedro Alves
2014-03-07 15:32   ` Eli Zaretskii [this message]
2014-03-07 15:38     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=831tyeqb2i.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox