From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-110995-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31622 invoked by alias); 7 Mar 2014 15:32:15 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 31603 invoked by uid 89); 7 Mar 2014 15:32:13 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout22.012.net.il
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 07 Mar 2014 15:32:11 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0N2200900O7FF100@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Fri, 07 Mar 2014 17:32:09 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N22009CNOHKFD10@a-mtaout22.012.net.il>; Fri, 07 Mar 2014 17:32:09 +0200 (IST)
Date: Fri, 07 Mar 2014 15:32:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH 1/3] Make the go32-nat.c target inherit inf-child.c.
In-reply-to: <1394205292-19784-2-git-send-email-palves@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <831tyeqb2i.fsf@gnu.org>
References: <1394205292-19784-1-git-send-email-palves@redhat.com> <1394205292-19784-2-git-send-email-palves@redhat.com>
X-IsSubscribed: yes
X-SW-Source: 2014-03/txt/msg00193.txt.bz2

> From: Pedro Alves <palves@redhat.com>
> Date: Fri,  7 Mar 2014 15:14:50 +0000
> 
> So that all native targets inherit a single "superclass".
> 
> Target methods that are set to or do the same as inf-child.c's are
> removed.
> 
> Tested by cross building on Fedora 17.
> 
> gdb/
> 2014-03-07  Pedro Alves  <palves@redhat.com>
> 
> 	* go32-nat.c: Include inf-child.h.
> 	(go32_ops): Delete global.
> 	(go32_close, go32_detach, go32_prepare_to_store, go32_can_run):
> 	Delete methods.
> 	(go32_create_inferior): Push the passed in target pointer instead
> 	of referencing go32_ops.
> 	(init_go32_ops): Delete function.  Moved parts to _initialize_go32_nat.
> 	(go32_target): New function, based on init_go32_ops, but inherit
> 	inf_child_target.
> 	(_initialize_go32_nat): Use go32_target.  Move parts of
> 	init_go32_ops here.

This is OK, thanks.